[Dev] catch only subprocess.CalledProcessError, with @Tishj

duckdb · Mar 17, 2024 · 6d0039c · 6d0039c
1 parent 0b3985d
commit 6d0039c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/scripts/package_build.py b/scripts/package_build.py
@@ -137,7 +137,7 @@ def get_git_describe():
     if len(override_git_describe) == 0:
         try:
             return subprocess.check_output(['git', 'describe', '--tags', '--long']).strip().decode('utf8')
-        except:
+        except subprocess.CalledProcessError:
             return "v0.0.0-0-deadbeeff"
     if len(override_git_describe.split('-')) == 2:
         return override_git_describe
@@ -150,7 +150,7 @@ def get_git_describe():
             + "-"
             + subprocess.check_output(['git', 'log', '-1', '--format=%h']).strip().decode('utf8')
         )
-    except:
+    except subprocess.CalledProcessError:
         return override_git_describe + "-" + "deadbeeff"
 
 

diff --git a/tools/pythonpkg/setup.py b/tools/pythonpkg/setup.py
@@ -375,7 +375,7 @@ def get_git_describe():
     if len(override_git_describe) == 0:
         try:
             return subprocess.check_output(['git', 'describe', '--tags', '--long']).strip().decode('utf8')
-        except:
+        except subprocess.CalledProcessError:
             return "v0.0.0-0-deadbeeff"
     if len(override_git_describe.split('-')) == 2:
         return override_git_describe
@@ -388,7 +388,7 @@ def get_git_describe():
             + "-"
             + subprocess.check_output(['git', 'log', '-1', '--format=%h']).strip().decode('utf8')
         )
-    except:
+    except subprocess.CalledProcessError:
         return override_git_describe + "-" + "deadbeeff"