Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse external workflows in Fuzzer CI #29

Merged
merged 12 commits into from
Sep 3, 2024

Conversation

hmeriann
Copy link
Contributor

@hmeriann hmeriann commented Aug 27, 2024

This PR makes test-fuzzer reuse Build DuckDB and Fuzzer workflows and connected to the #22

@hmeriann hmeriann changed the title try to reuse external workflows Reuse external workflows in Fuzzer CI Aug 27, 2024
@hmeriann hmeriann force-pushed the make-fuzzer-ci-use-reusable-wf branch from e11ec51 to 83c353d Compare August 28, 2024 13:22
Copy link
Collaborator

@Tmonster Tmonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise it looks good

data: ${{ matrix.data }}
timeout-minutes: 20
max_queries: 10
dry: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dry should be true I think
dry is basically meant to mean that the program should be run without attempting to alter any github issues.
If we want to test that the fuzzer CI still works, we want to test that the fuzzer CI debug build can be built, but we don't need to file any github issues or check other issues

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@hmeriann hmeriann requested a review from Tmonster August 29, 2024 15:29
Copy link
Collaborator

@Tmonster Tmonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Tmonster Tmonster merged commit 0008ffd into duckdb:main Sep 3, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants