mention random_nums_config files in the CMakes

CMakeLists.txt

@@ -21,6 +21,7 @@ add_subdirectory(src/third_party/sqlsmith)
 set(EXTENSION_SOURCES src/sqlsmith_extension.cpp
         src/statement_generator.cpp
         src/statement_simplifier.cpp
+        src/random_nums_config.cpp
         src/fuzzyduck.cpp ${EXTENSION_OBJECT_FILES})
 
 build_static_extension(${TARGET_NAME} ${EXTENSION_SOURCES})

src/CMakeLists.txt

@@ -7,7 +7,7 @@ include_directories(third_party/sqlsmith/include)
 add_subdirectory(third_party)
 
 set(SQLSMITH_SOURCES
-    sqlsmith_extension.cpp statement_generator.cpp statement_simplifier.cpp
+    sqlsmith_extension.cpp statement_generator.cpp statement_simplifier.cpp random_nums_config.cpp
     fuzzyduck.cpp ${SQLSMITH_OBJECT_FILES})
 
 build_static_extension(sqlsmith ${SQLSMITH_SOURCES})

src/include/random_nums_config.hpp

@@ -13,30 +13,23 @@
 namespace duckdb {
 
 class RandomNumsConfig {
-private:
-
-    idx_t select_percentage = 60;
-	idx_t attach_percentage = 40;
-	idx_t attach_use_percentage = 50;
-	idx_t detach_percentage = 60;
-	idx_t set_percentage = 30;
-	idx_t delete_percentage = 40;
-
 public:
-    RandomNumsConfig() {
 
-    };
+	idx_t select_percentage;
+	idx_t attach_percentage;
+	idx_t attach_use_percentage;
+	idx_t detach_percentage;
+	idx_t set_percentage;
+	idx_t delete_percentage;
+
+    RandomNumsConfig();
 	~RandomNumsConfig();
 
+	// is it better to return an object initialised with fetched/default params?
 	// read file and update default values
-	void getConfigFromFile(duckdb_string_t file_path) {
-
-	}
-
+	void GetConfigFromFile(duckdb_string_t file_path);
 	// set default values
-	void GetDefaultConfig() {
-
-	}
+	void GetDefaultConfig();
 
 };
 

src/include/statement_generator.hpp

@@ -11,7 +11,6 @@
 #include "duckdb.hpp"
 #include "duckdb/parser/parsed_data/detach_info.hpp"
 #include "duckdb/parser/query_node.hpp"
-#include "src/include/random_nums_config.hpp"
 
 #define TESTING_DIRECTORY_NAME "duckdb_unittest_tempdir"
 
@@ -41,7 +40,6 @@ class StatementGenerator {
 	friend class ExpressionDepthChecker;
 	friend class AggregateChecker;
 	friend class WindowChecker;
-	RandomNumsConfig random_nums_config;
 
 public:
 	StatementGenerator(ClientContext &context);

src/random_nums_config.cpp

@@ -1,12 +1,26 @@
 #include "random_nums_config.hpp"
 
 namespace duckdb {
-    void getConfigFromFile(duckdb_string_t file_path) {
+
+RandomNumsConfig::RandomNumsConfig() {
+
+}
 
-	}
+RandomNumsConfig::~RandomNumsConfig() {
+}
 
-	// set default values
-	void GetDefaultConfig() {
-
-	}
+
+void RandomNumsConfig::GetConfigFromFile(duckdb_string_t file_path) {
+
+}
+
+// set default values
+void RandomNumsConfig::GetDefaultConfig() {
+    idx_t select_percentage = 60;
+    idx_t attach_percentage = 40;
+    idx_t attach_use_percentage = 50;
+    idx_t detach_percentage = 60;
+    idx_t set_percentage = 30;
+    idx_t delete_percentage = 40;
+}
 }

src/statement_generator.cpp

@@ -25,6 +25,7 @@
 #include "duckdb/parser/statement/set_statement.hpp"
 #include "duckdb/parser/statement/update_statement.hpp"
 #include "duckdb/parser/tableref/list.hpp"
+#include "random_nums_config.hpp"
 
 namespace duckdb {