Fix ST_Read_Meta() type mismatch errors on Linux #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is caused by an uninitialized EOF variable in the GDAL file handler, which if EOF is checked before a seek, leads to an intermittent SQL Type Mismatch error in release builds, and a runtime error crash in debug builds.
|
Hi! Good job digging into this and thanks a lot for the PR! |
|
Don't worry about the failing CI, we need to update duckdb and create a stable branch, but I'll take care of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #451
The error is caused by an uninitialized EOF variable in the GDAL file handler, which if EOF is checked before a seek, leads to an intermittent SQL Type Mismatch error in release builds, and a runtime error crash in debug builds.