-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
231 refactoring #398
231 refactoring #398
Conversation
Thanks a lot @fishermans for those fixes 🙏 ! Merging and testing on my side, I'll try a release ASAP Thank you to @abimarank for the review as well EDIT: tests OK 👍 |
@fishermans - nitpicking on your pull request: you don't need to change the versions (like 2.3.1), I do it when I release I have a script which automates it ( Also I'm following |
Plugin uploaded pending verification, thanks again |
Thanks a lot @dubreuia! Maybe we can clean up some of the old tickets to have a better overview of what still needs to be done. I guess, the option "Remove unused suppressed warning annotation" should be removed as long as this function is not working as expected. It removes too much at the moment and I haven't figured out how to fix it. See #87 . |
Hi @dubreuia,
I spent some more time keeping this wonderful plugin updated.
Main change is moving to services and removing component implementation regarding https://plugins.jetbrains.com/docs/intellij/dynamic-plugins.html.
I also implemented a FileDocumentManagerListener and registering it to the EP which should be a cleaner way then using the message bus. At this point, we can decide whether to register multiple Listener for each project or using an application based listener for all projects and iterating over the projects. As long as changed documents are held systemwide, it would not make any difference from my-point-of-view.
I tested it on Idea, RubyMine and Resharper.
Please review my changes when you find some time.
BR
Tiemo