Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tester): support duration string #32

Merged
merged 1 commit into from
Feb 7, 2022
Merged

feat(tester): support duration string #32

merged 1 commit into from
Feb 7, 2022

Conversation

justxuewei
Copy link
Contributor

No description provided.

@LaurenceLiZhixin
Copy link
Contributor

LaurenceLiZhixin commented Jan 18, 2022 •
edited
Loading

@justxuewei 目前还是从进程开启的时候计算平均值rt/tps 是吧。
我后面吧我修改后的 tester 也推上来，跟你的是不冲突的，并列关系的工具

@justxuewei
Copy link
Contributor Author

@justxuewei 目前还是从进程开启的时候计算平均值rt/tps 是吧。

是的，你是需要记录瞬时 TPS？关键是一个请求横跨了两个时间，到底算那个时间段的 TPS 我没想好 :|

@LaurenceLiZhixin
Copy link
Contributor

@justxuewei rt再长也就几秒钟，我是按照返回时间计算的。

@justxuewei
Copy link
Contributor Author

@justxuewei rt再长也就几秒钟，我是按照返回时间计算的。

那没问题，这个好改的。我后面专门提一个 PR 解决这个问题。

@AlexStocks AlexStocks merged commit f5c3efc into dubbogo:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenceLiZhixin LaurenceLiZhixin LaurenceLiZhixin approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

@ztelur ztelur ztelur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justxuewei @LaurenceLiZhixin @ztelur @AlexStocks