Expand config options to allow custom LDAP filter, samba mode #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Default account filter assumes the objectClass of user entries, which doesn't suit AD or RFC2807bis directories. This can now be set using the environment variable LSSP_ACCOUNT_FILTER, as with other config settings.
- For users with open relays (e.g. on internal docker networks), configure PHPMailer to disable authentication if no SMTP_USER and SMTP_PASS are supplied.
- Add LDAP_SAMBA_MODE default to env-defaults - Add samba_mode setting in config.inc.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new config options (documented in README.md):
$ldap_filterconfig value for LSSP, defaults to the previously-hard-coded filter value of(&(objectClass=person)($ldap_login_attribute={login}))sambaNTPassword/sambaLMPasswordattributes when changing theuserPassword. Defaults to the previously-hard-coded value offalse.$mail_smtp_authtofalseif noSMTP_USERandSMTP_PASSare set, allowing unauthenticated SMTP.$mail_smtp_authenabled even when the credentials were unset.Fix a minor syntax error in assets/scripts/functions that was putting errors in the log output of the container on startup.