Skip to content

Commit

Permalink
Remove workaround added to resolve multi-card stall issue (vllm-proje…
Browse files Browse the repository at this point in the history
…ct#387)

This PR removes additional `multiprocessing.Process` object created as a
workaround for resolving multi-card stall issue.
  • Loading branch information
SanjuCSudhakaran authored Oct 14, 2024
1 parent 2d2bf7a commit 9df1d4a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 31 deletions.
18 changes: 3 additions & 15 deletions tests/lora/test_llama_hpu.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
from multiprocessing import Process
from typing import List

from conftest import cleanup
Expand Down Expand Up @@ -78,23 +77,12 @@ def _test_llama_lora(sql_lora_files, tp_size):


def test_llama_lora_1x(sql_lora_files):
p = Process(target=_test_llama_lora, args=(sql_lora_files, 1))
p.start()
p.join()
assert p.exitcode == 0
_test_llama_lora(sql_lora_files, 1)


def test_llama_lora_2x(sql_lora_files):
# Work-around to resolve stalling issue in multi-card scenario
p = Process(target=_test_llama_lora, args=(sql_lora_files, 2))
p.start()
p.join()
assert p.exitcode == 0
_test_llama_lora(sql_lora_files, 2)


def test_llama_lora_4x(sql_lora_files):
# Work-around to resolve stalling issue in multi-card scenario
p = Process(target=_test_llama_lora, args=(sql_lora_files, 4))
p.start()
p.join()
assert p.exitcode == 0
_test_llama_lora(sql_lora_files, 4)
19 changes: 3 additions & 16 deletions tests/lora/test_multilora_hpu.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
from multiprocessing import Process
from typing import List, Optional, Tuple

from vllm import EngineArgs, LLMEngine, RequestOutput, SamplingParams
Expand Down Expand Up @@ -107,24 +106,12 @@ def _test_llama_multilora(sql_lora_files, tp_size):


def test_llama_multilora_1x(sql_lora_files):
# Work-around to resolve stalling issue in multi-card scenario
p = Process(target=_test_llama_multilora, args=(sql_lora_files, 1))
p.start()
p.join()
assert p.exitcode == 0
_test_llama_multilora(sql_lora_files, 1)


def test_llama_multilora_2x(sql_lora_files):
# Work-around to resolve stalling issue in multi-card scenario
p = Process(target=_test_llama_multilora, args=(sql_lora_files, 2))
p.start()
p.join()
assert p.exitcode == 0
_test_llama_multilora(sql_lora_files, 2)


def test_llama_multilora_4x(sql_lora_files):
# Work-around to resolve stalling issue in multi-card scenario
p = Process(target=_test_llama_multilora, args=(sql_lora_files, 4))
p.start()
p.join()
assert p.exitcode == 0
_test_llama_multilora(sql_lora_files, 4)

0 comments on commit 9df1d4a

Please sign in to comment.