Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Swift 5.1, version to 2.0. #48

Merged
merged 2 commits into from
Mar 31, 2020

Conversation

jshier
Copy link
Contributor

@jshier jshier commented Mar 20, 2020

This PR makes no logic changes, but instead updates the app for Swift 5.1 and other environment updates. This includes:

  • A proper Ruby environment using .ruby-version and .ruby-gemset.
  • More SwiftLint warnings and fixes.
  • Updated dependencies.
  • Updated Travis config.
  • Versioning to 2.0.
  • Update to Swift 5.1, including implicit returns.
  • Deployment iOS version to 10.0.
  • Removed executable flag from Gemfile, Podfile, and LICENSE.

pod 'SwiftLint'

pod 'Quick'
pod 'Nimble'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

inherit! :search_paths
pod 'SwiftLint'

pod 'Quick'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

inherit! :search_paths
pod 'SwiftLint'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/TrailingWhitespace: Trailing whitespace detected.

target 'LaunchGate' do
platform :ios, '8.3'
target 'LaunchGateTests' do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@@ -1,18 +1,13 @@
source 'https://github.com/CocoaPods/Specs.git'
platform :ios, '10.0'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@dtrenz dtrenz merged commit fec776a into dtrenz:develop Mar 31, 2020
@jshier jshier deleted the swift-5.1-version-2 branch March 31, 2020 17:18
@dtrenz
Copy link
Owner

dtrenz commented Apr 8, 2020

Released in 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants