Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overflow during validation on 32-bit machines. #9

Merged
merged 1 commit into from
Oct 19, 2019
Merged

Fix overflow during validation on 32-bit machines. #9

merged 1 commit into from
Oct 19, 2019

Conversation

msizanoen1
Copy link
Contributor

When testing this on a 32 bit machine, I observed the proc macro panic because of left shift overflow during validation. This PR fix overflow during validation on 32-bit machines.

dtolnay
dtolnay approved these changes Oct 19, 2019
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 83f580c into dtolnay:master Oct 19, 2019
@dtolnay
Copy link
Owner

dtolnay commented Oct 19, 2019

Published in 0.1.2.

@msizanoen1 msizanoen1 deleted the fix-overflow-32 branch October 20, 2019 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msizanoen1 @dtolnay