-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.0.26 causes Clippy warnings on older versions of Rust #141
Comments
Looks like nonstandard_macro_braces is available from Rust 1.51. @dtolnay Can we get a response? Whether you are able to revert a change that is no longer needed and is causing actual semver problems for people still on Rust <=1.50 that are trying to use your library, or whether you want to disregard anyone using versions of Rust that are more than a few months old? Please consider that there are developers out there who only have the time and opportunity to upgrade through Rust versions maybe two or three times a year. Not looking for a service contract covering years of maintenance, here. Just to undo a couple commits that aren't doing anything helpful anymore. |
looks like this was fixed upstream in clippy - rust-lang/rust-clippy#7431 i think this can probably be closed |
The newest release, 1.0.26, causes Clippy warnings on versions of Rust that precede the
nonstandard_macro_braces
lint. Specifically, the warningunknown clippy lint: clippy::nonstandard_macro_braces
pops up in places withderive(Error)
. This breaks CI builds that use Clippy and have an MSRV older thannonstandard_macro_braces
.The text was updated successfully, but these errors were encountered: