Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0.26 causes Clippy warnings on older versions of Rust #141

Closed
YuhanLiin opened this issue Jul 7, 2021 · 3 comments
Closed

Version 1.0.26 causes Clippy warnings on older versions of Rust #141

YuhanLiin opened this issue Jul 7, 2021 · 3 comments

Comments

@YuhanLiin
Copy link

The newest release, 1.0.26, causes Clippy warnings on versions of Rust that precede the nonstandard_macro_braces lint. Specifically, the warning unknown clippy lint: clippy::nonstandard_macro_braces pops up in places with derive(Error). This breaks CI builds that use Clippy and have an MSRV older than nonstandard_macro_braces.

@damianwadley
Copy link

See #140, where I'm still hoping @dtolnay will consider reverting the change.

@damianwadley
Copy link

Looks like nonstandard_macro_braces is available from Rust 1.51.

@dtolnay Can we get a response? Whether you are able to revert a change that is no longer needed and is causing actual semver problems for people still on Rust <=1.50 that are trying to use your library, or whether you want to disregard anyone using versions of Rust that are more than a few months old? Please consider that there are developers out there who only have the time and opportunity to upgrade through Rust versions maybe two or three times a year.

Not looking for a service contract covering years of maintenance, here. Just to undo a couple commits that aren't doing anything helpful anymore.

Turbo87 added a commit to glide-rs/openaip-rs that referenced this issue Jul 31, 2021
Turbo87 added a commit to glide-rs/openaip-rs that referenced this issue Jul 31, 2021
Turbo87 added a commit to glide-rs/openaip-rs that referenced this issue Jul 31, 2021
@danieleades
Copy link

looks like this was fixed upstream in clippy - rust-lang/rust-clippy#7431

i think this can probably be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants