Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method to Punctuated to remove trailing punctuation #1043

Closed
programmerjake opened this issue Aug 3, 2021 · 0 comments · Fixed by #1442
Closed

Add method to Punctuated to remove trailing punctuation #1043

programmerjake opened this issue Aug 3, 2021 · 0 comments · Fixed by #1442

Comments

@programmerjake
Copy link
Contributor

I have a Path for an enum variant like my_mod::MyType::MyVariant, and I can remove the MyVariant part with path.segments.pop(), however that gives me a path like my_mod::MyType:: which is syntatically incorrect for a Path to a type.

Punctuated should have a method to remove the trailing ::.
programmerjake added a commit to programmerjake/syn that referenced this issue Apr 11, 2023
@programmerjake
add Punctuated::pop_punct()
81c5035 
Fixes: dtolnay#1043
@programmerjake programmerjake mentioned this issue Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add Punctuated::pop_punct() programmerjake/syn
1 participant
@programmerjake