Merge leftmost_subexpression_with_operator and leftmost_subexpression…

… into one method
dtolnay · Jan 1, 2025 · 19d93ba · 19d93ba
1 parent 15220b9
commit 19d93ba
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 23 deletions.
diff --git a/src/expr.rs b/src/expr.rs
@@ -3306,7 +3306,7 @@ pub(crate) mod printing {
             &e.left,
             Precedence::of(&e.left) <= Precedence::Range,
             tokens,
-            fixup.leftmost_subexpression(),
+            fixup.leftmost_subexpression_with_operator(false, false),
         );
         e.eq_token.to_tokens(tokens);
         print_subexpression(
@@ -3475,7 +3475,11 @@ pub(crate) mod printing {
             &e.expr,
             Precedence::of(&e.expr) < Precedence::Cast,
             tokens,
-            fixup.leftmost_subexpression(),
+            fixup.leftmost_subexpression_with_operator(
+                #[cfg(feature = "full")]
+                false,
+                false,
+            ),
         );
         e.as_token.to_tokens(tokens);
         e.ty.to_tokens(tokens);

diff --git a/src/fixup.rs b/src/fixup.rs
@@ -195,7 +195,11 @@ impl FixupContext {
     ///
     /// Not every expression has a leftmost subexpression. For example neither
     /// `-$a` nor `[$a]` have one.
-    pub fn leftmost_subexpression(self) -> Self {
+    pub fn leftmost_subexpression_with_operator(
+        self,
+        #[cfg(feature = "full")] next_operator_can_begin_expr: bool,
+        next_operator_can_begin_generics: bool,
+    ) -> Self {
         FixupContext {
             #[cfg(feature = "full")]
             stmt: false,
@@ -209,10 +213,10 @@ impl FixupContext {
             #[cfg(feature = "full")]
             rightmost_subexpression: false,
             #[cfg(feature = "full")]
-            next_operator_can_begin_expr: false,
+            next_operator_can_begin_expr,
             #[cfg(feature = "full")]
             next_operator_can_continue_expr: true,
-            next_operator_can_begin_generics: false,
+            next_operator_can_begin_generics,
             ..self
         }
     }
@@ -242,22 +246,6 @@ impl FixupContext {
         }
     }
 
-    /// Transform this fixup into the one that should apply when printing a
-    /// leftmost subexpression followed by punctuation that is legal as the
-    /// first token of an expression.
-    pub fn leftmost_subexpression_with_operator(
-        self,
-        #[cfg(feature = "full")] next_operator_can_begin_expr: bool,
-        next_operator_can_begin_generics: bool,
-    ) -> Self {
-        FixupContext {
-            #[cfg(feature = "full")]
-            next_operator_can_begin_expr,
-            next_operator_can_begin_generics,
-            ..self.leftmost_subexpression()
-        }
-    }
-
     /// Transform this fixup into the one that should apply when printing the
     /// rightmost subexpression of the current expression.
     ///
@@ -393,10 +381,14 @@ fn test_leftmost_rightmost_invariant() {
         };
         assert_eq!(i, BITS);
         assert_eq!(
-            fixup.leftmost_subexpression().rightmost_subexpression(),
+            fixup
+                .leftmost_subexpression_with_operator(false, false)
+                .rightmost_subexpression(),
             FixupContext {
                 rightmost_subexpression: true,
-                ..fixup.rightmost_subexpression().leftmost_subexpression()
+                ..fixup
+                    .rightmost_subexpression()
+                    .leftmost_subexpression_with_operator(false, false)
             },
         );
     }