Add pass-through for i128/u128 deserialization #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [default implementation](https://github.com/serde-rs/serde/blob/33438850a6a8b0a3550619a60885cfc6f224e53f/serde/src/de/mod.rs#L977-L989) for a deserializer's dispatch of a (i|u)128 is one that `Error`s out into a `Custom` message indicating non-support. This enables the common, if debatable, choice of letting implementers avoid bothering with (i|u)128. But since the present adapter does not implement `deserialize_(i|u)128`, it also passes to this default behavior, rather than passing through its generic argument, which is the expected behavior of a pass-through. This PR implements that pass-through. Should the inner serializer then not implement (i|u)128 deserialization, it would default to the common behavior (a custom error), but should it do so (as is crucially the case for libra) it would then function as expected rather than error out.
|
Published in 0.1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default implementation for a deserializer's dispatch of a (i|u)128 is one that
Errors out into aCustommessage indicating non-support. This enables the common, if debatable, choice of letting implementers avoid bothering with (i|u)128.But since the present adapter does not implement
deserialize_(i|u)128, it also passes to this default behavior, rather than passing through its generic argument, which is the expected behavior of a pass-through.This PR implements that pass-through. Should the inner serializer then not implement (i|u)128 deserialization, it would default to the common behavior (a custom error), but should it do so (as is crucially the case for libra) it would then function as expected rather than error out.