Add a feature for linking to proc-macro
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a feature to this crate which enables linking to the upstream `proc_macro` crate. This should help this compile on targets which don't have `proc_macro` and allow it to also be suitable for embedding in Rust binaries. This feature is turned on by default for backwards compatibility right now.
alexcrichton
force-pushed
the
proc-macro-feature
branch
from
0e575de to
0e8e7f4
Compare
This was referenced Feb 22, 2018
dtolnay
reviewed
Feb 22, 2018
Cargo.toml
Outdated
| @@ -27,3 +27,6 @@ unicode-xid = "0.1" | |||
| # When disabled: emulate the same API as the nightly compiler's proc_macro crate | |||
| # but in a way that works on all stable compilers >=1.15.0. | |||
| nightly = [] | |||
There was a problem hiding this comment.
I am going to add nightly = ["proc-macro"] so that default-features = false, features = ["nightly"] can work.
|
Oh right yes, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a feature to this crate which enables linking to the
upstream
proc_macrocrate. This should help this compile on targetswhich don't have
proc_macroand allow it to also be suitable forembedding in Rust binaries.
This feature is turned on by default for backwards compatibility right
now.