Circumvent clippy::octal_escapes lint in generated literals #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error: octal-looking escape in string literal
--> tests/test.rs:118:25
|
118 | Literal::string("a\00b\07c\08d\0e\0").to_string(),
| ^^^^^^^^^^^^^^^^^^^^
|
= help: octal escapes are not supported, `\0` is always a null character
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#octal_escapes
= note: `-D clippy::octal-escapes` implied by `-D clippy::all`
help: if an octal escape was intended, use the hexadecimal representation instead
|
118 | Literal::string("a\x00b\x07c\08d\0e\0").to_string(),
| ~~~~~~~~~~~~~~~~~~~~~~
help: if the null character is intended, disambiguate using
|
118 | Literal::string("a\x000b\x007c\08d\0e\0").to_string(),
| ~~~~~~~~~~~~~~~~~~~~~~~~
error: octal-looking escape in byte string literal
--> tests/test.rs:155:30
|
155 | Literal::byte_string(b"a\00b\07c\08d\0e\0").to_string(),
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: octal escapes are not supported, `\0` is always a null byte
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#octal_escapes
help: if an octal escape was intended, use the hexadecimal representation instead
|
155 | Literal::byte_string(b"a\x00b\x07c\08d\0e\0").to_string(),
| ~~~~~~~~~~~~~~~~~~~~~~~
help: if the null byte is intended, disambiguate using
|
155 | Literal::byte_string(b"a\x000b\x007c\08d\0e\0").to_string(),
| ~~~~~~~~~~~~~~~~~~~~~~~~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #363.