Add string-based CallSite variant to wrapper enums #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preliminary not-yet-optimized attempt at dtolnay/quote#160. It's currently showing about 20% improvement on the
quotecrate's benchmark, and passes quote's test suite and serde's test suite. There is still lots more to implement and optimize though.In this draft, currently only the
inside_proc_macro() == trueside of things has been implemented. Some similar changes would need to be made in the non-macro codepaths because the same optimization of storing spanless tokens as strings is useful there as well.This is a
proc_macro2-only change with no change in the public API i.e. nothing that needs to change inquoteto take advantage of this.