Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up changes to non_exhaustive_omitted_patterns lint #53

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Jan 4, 2024

Context: dtolnay/syn#1522

    warning: the lint level must be set on the whole match
       --> src/lib.rs:190:9
        |
    189 |         #[cfg_attr(all(test, exhaustive), deny(non_exhaustive_omitted_patterns))]
        |                                                ------------------------------- remove this attribute
    190 |         _ => {}
        |         ^
        |
        = help: it no longer has any effect to set the lint level on an individual match arm
    help: set the lint level on the whole match
        |
    167 +     #[deny(non_exhaustive_omitted_patterns)]
    168 |     match ret {
        |

    warning: the lint level must be set on the whole match
      --> noexcept-impl/src/lib.rs:69:9
       |
    68 |         #[cfg_attr(all(test, exhaustive), deny(non_exhaustive_omitted_patterns))]
       |                                                ------------------------------- remove this attribute
    69 |         _ => {}
       |         ^
       |
       = help: it no longer has any effect to set the lint level on an individual match arm
    help: set the lint level on the whole match
       |
    46 +     #[deny(non_exhaustive_omitted_patterns)]
    47 |     match ret {
       |
@dtolnay dtolnay merged commit 5f2f9b4 into master Jan 4, 2024
20 checks passed
@dtolnay dtolnay deleted the exhaustive branch January 4, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant