This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
Distinguish different CLA instances during restart #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There may be a situation where there are multiple PeerDisappeared-messages for the same CLA waiting to be processed. This might cause the manager to restart the same CLA multiple times in quick succession. To prevent this, we can check if the pointer to the CLA from the PeerDisappeared-message points to the same instance as the one currently stored in the manager's `convs` map.
CryptoCopter
force-pushed
the
cla_instances
branch
from
2ef1648 to
8cda77f
Compare
oxzi
approved these changes
Jun 3, 2021
|
So, I ran our large setup, without success. Or, success, rather. This case is never triggered, i.e., the pointers to the CLAs are always the same, meaning there are no CLAs broken down accidentally. I don't know what to do with this now. I guess this PR doesn't make things worse? |
|
This case is never triggered, i.e., the pointers to the CLAs are
always the same, meaning there are no CLAs broken down accidentally.
I am not sure if this is a good or bad thing.
At least no bug seems to be there.
I don't know what to do with this now. I guess this PR doesn't make
things worse?
Certainly, this change does not do any harm, since it indicates an
undesirable state.
|
adur1990
pushed a commit
that referenced
this pull request
Aug 16, 2021
As can be seen in recent issues and PRs (#39, #40, #41, #42, #43, #45), there is an issue in dtn7-go that results in a deadlock after some time, making it impossible to sent bundles. To be able to test and debug this issue, some more extensive tests are required. Thus, we developed a test infrastructure to simulate multiple virtual nodes using the [CORE emulator](https://github.com/coreemu/core). This tests environment is located in the [dtn7-playground](https://github.com/dtn7/dtn7-playground) repository. To be able to trigger these tests, this PR adds a workflow file, that uses the [repository_dispatch event](https://docs.github.com/en/actions/reference/events-that-trigger-workflows#repository_dispatch) sent to the dtn7-playground repo.
oxzi
pushed a commit
that referenced
this pull request
Aug 16, 2021
* Workflow for extended tests As can be seen in recent issues and PRs (#39, #40, #41, #42, #43, #45), there is an issue in dtn7-go that results in a deadlock after some time, making it impossible to sent bundles. To be able to test and debug this issue, some more extensive tests are required. Thus, we developed a test infrastructure to simulate multiple virtual nodes using the [CORE emulator](https://github.com/coreemu/core). This tests environment is located in the [dtn7-playground](https://github.com/dtn7/dtn7-playground) repository. To be able to trigger these tests, this PR adds a workflow file, that uses the [repository_dispatch event](https://docs.github.com/en/actions/reference/events-that-trigger-workflows#repository_dispatch) sent to the dtn7-playground repo. * Fix copyright header Co-authored-by: Artur Sterz <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be a situation where there are multiple PeerDisappeared-messages for the same CLA waiting to be processed.
This might cause the manager to restart the same CLA multiple times in quick succession.
To prevent this, we can check if the pointer to the CLA from the PeerDisappeared-message points to the same instance as the one currently stored in the manager's
convsmap.