Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Travis to GitHub Actions #1

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Switch from Travis to GitHub Actions #1

merged 2 commits into from
Nov 20, 2020

Conversation

mogren
Copy link
Contributor

@mogren mogren commented Nov 18, 2020

Minor PR to make cboring use GitHub Actions, just like dtn7-go.

Changes:

  • Add Action running go build, go test and golangci-lint on code push and PRs
  • Remove .travis.yml config file
  • Add a .gitignore file
  • Update BP draft link in Readme to revision 29
  • Fix go fmt issues in test files

Sample Action run: https://github.com/mogren/cboring/actions/runs/371183684

Enable golangci-lint on Push and PRs
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this update. Especially the integration of golangci-lint is a great bonus. Would you please adjust the banner in the README.md?

README.md Outdated Show resolved Hide resolved
Add CI badge

Co-authored-by: Alvar <[email protected]>
@mogren
Copy link
Contributor Author

mogren commented Nov 19, 2020

@oxzi Thanks, I should have seen that the banner needed to be updated as well. Thanks for the suggestion, applied it.

@mogren mogren requested a review from oxzi November 19, 2020 17:11
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks again!

@oxzi oxzi merged commit 10e1b5c into dtn7:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants