Fix for where WITH_TCP is defined, WITH_WS is not. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function coap_pdu_parse2() as changed by iotivity patches has a block of code bracketed by #if defined(WITH_TCP) || defined(WITH_WS) the problem is this block contains a reference to a structure member that is defined only if WITH_WS is defined, and it is possible to build this code in iotivity in the presence of WITH_TCP and the absence of WITH_WS. Whether that should ever happen is a separate question; the change keeps these two conditions separate so this can be used in the iotivity CI system which does build some targets in the way noted. Signed-off-by: Mats Wichmann <[email protected]>
dthaler
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function coap_pdu_parse2() as changed by iotivity patches has a
block of code bracketed by
#if defined(WITH_TCP) || defined(WITH_WS)
the problem is this block contains a reference to a structure member
that is defined only if WITH_WS is defined, and it is possible to build
this code in iotivity in the presence of WITH_TCP and the absence of
WITH_WS. Whether that should ever happen is a separate question; the
change keeps these two conditions separate so this can be used in the
iotivity CI system which does build some targets in the way noted.
Signed-off-by: Mats Wichmann [email protected]