Compilation failure in coap_io.c when NDEBUG=1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currenlty building libcoap with NDEBUG=1 causes below compilation error : "coap_io.c: error : 'COAP_MAX_PDU_SIZE': undeclared identifier". <pdu.h> file which contains the definition of 'COAP_MAX_PDU_SIZE' is included only when NDEBUG=0 (inside <debug.h>). Building iotivity with RELEASE=1 and TEST=1, fails because of above reason. Proposed fix is to include <pdu.h> inside coap_io.c.
|
@ajsaini thanks, fixed! |
dthaler
pushed a commit
that referenced
this pull request
Jan 27, 2017
Pulling changes from dthaler/libcoap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currenlty building libcoap with NDEBUG=1 causes below compilation error :
"coap_io.c: error : 'COAP_MAX_PDU_SIZE': undeclared identifier".
<pdu.h> file which contains the definition of 'COAP_MAX_PDU_SIZE' is
included only when NDEBUG=0 (inside <debug.h>).
Building iotivity with RELEASE=1 and TEST=1, fails because of above
reason. Proposed fix is to include <pdu.h> inside coap_io.c.