-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leeky effects #145
Open
The1Penguin
wants to merge
7
commits into
main
Choose a base branch
from
effective
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Leeky effects #145
+112
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The1Penguin
force-pushed
the
effective
branch
from
November 2, 2024 13:02
1d3039f
to
04b9f68
Compare
The1Penguin
force-pushed
the
effective
branch
from
November 2, 2024 13:47
8f0496b
to
5737640
Compare
The1Penguin
commented
Nov 2, 2024
Overall, think this shows a bit more clearly where the effects come from |
The1Penguin
requested review from
Rembane,
malmz,
Titanothere,
rachelambda,
erikOrtenberg and
Discomannen
November 20, 2024 20:52
Rembane
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I've heard good things about leeky effects. Lets see if they can deliver food too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I got introduced to effectful and also watched this video. This got me inspired to replace our mtl stack with effects, since we do not use a lot and this looked cool ;P