Fix kåren misshap from today #133
Conversation
| @@ -120,7 +120,7 @@ parse lang = | |||
| menuParser :: Value -> Parser Menu | |||
| menuParser = withObject "Menu Object" $ \obj -> | |||
| Menu | |||
| <$> (obj .: "dishType" >>= (.: "name")) | |||
| <$> (obj .: "dishType" >>= maybe (pure "Unknown menu") (.: "name")) | |||
There was a problem hiding this comment.
Does this mean that Kåren has changed the payload to sometimes not return an object with a "name"-field?
There was a problem hiding this comment.
This occured once, which was the morning of today, the 14th of august. Later, around ten, the payload was updated and looked as it has done before. This is a precaution if it would happen again.
| "parses a blob of JSON without error, but it has an dish without dishType" | ||
| ( testFun | ||
| (Right [ Menu | ||
| (T.pack "Unknown menu") |
There was a problem hiding this comment.
Oh. I see. Lovely surprise!
Kårres sent a payload which included a dish that didn't mention the dishType. This would allow such payloads to show up, but listed as "Unknown Menu", which allows the ones that properly parse to also be shown along this oddity.
Added a comment of what the fix does and why it was needed, kinda |
|
@The1Penguin Awesome! Thank you! |
No description provided.