Make Kårres properly display when there is no lunch #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The1Penguin
reviewed
Jun 5, 2024
src/Model/Karen.hs
Outdated
| @@ -108,6 +108,7 @@ parse lang = | |||
| >=> mapM menuParser | |||
| ) | |||
| ) | |||
| >=> pure . filter ((/= "stängt") . _mFood) | |||
There was a problem hiding this comment.
Could instead lens for it to be more inline with the rest of the code
There was a problem hiding this comment.
Could also use filterM and make the fetch a pure
The1Penguin
reviewed
Jun 5, 2024
Comment on lines
+31
to
35
| data Menu = Menu | ||
| { _mName :: Text | ||
| , _mFood :: Text | ||
| } | ||
| deriving (Eq, Show) |
There was a problem hiding this comment.
Suggested change
| data Menu = Menu | |
| { _mName :: Text | |
| , _mFood :: Text | |
| } | |
| deriving (Eq, Show) | |
| data Menu = Menu | |
| { _mName :: Text | |
| , _mFood :: Text | |
| } | |
| deriving (Eq, Show) | |
| makeLenses ''Menu |
would create lenses with the names mName and mFood.
The1Penguin
reviewed
Jun 5, 2024
src/Model/Karen.hs
Outdated
| @@ -108,6 +110,7 @@ parse lang = | |||
| >=> mapM menuParser | |||
| ) | |||
| ) | |||
| >=> filterM (((/= "stängt") <$>) <$> (^.^ mFood)) | |||
There was a problem hiding this comment.
The1Penguin
reviewed
Jun 5, 2024
Comment on lines
+33
to
+35
| (^.^) :: Monad m => s -> Getting a s a -> m a | ||
| (^.^) = (pure .) . (^.) | ||
| infixl 8 ^.^ |
There was a problem hiding this comment.
They are so happy now ^.^
The1Penguin
reviewed
Jun 5, 2024
| deriving (Eq, Show) | ||
|
|
||
| makeLenses ''Menu |
There was a problem hiding this comment.
Lenses are good to be inline with the style of code in this repo
|
Snälla nej |
|
This fixes #130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.