Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get time-out-resilience by using req HTTP client #122

Closed
wants to merge 10 commits into from

Conversation

Rembane
Copy link
Contributor

@Rembane Rembane commented Sep 27, 2023

Replace http-client with req and use all the sweet retry
functionality from req. req uses a Fibonacci sequence to back off.
This also lets us remove loads of code.

Close #93.

@Rembane Rembane linked an issue Sep 27, 2023 that may be closed by this pull request
@Rembane Rembane requested review from malmz, The1Penguin and a team September 27, 2023 21:31
Replace `http-client` with `req` and use all the sweet retry
functionality from `req`. `req` uses a Fibonacci sequence to back off.
This also lets us remove loads of code.

Close #93.
Copy link
Contributor

@The1Penguin The1Penguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, makes the code more readable and easy to get into

@The1Penguin
Copy link
Contributor

Added via command line since github was sad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time out resilience
4 participants