Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Express restaurant because it's gone in reality #111

Merged
merged 2 commits into from
Sep 24, 2023

Conversation

Jassob
Copy link
Contributor

@Jassob Jassob commented Sep 13, 2023

It's good if mat reflects reality. This commit makes mat more reality reflective and fixes #110.

Thank you Rembane for the above commit message.

It's good if mat reflects reality. This commit makes mat more reality
reflective and closes #110.

Thank you @Rembane for the above commit message.
test/Main.hs Outdated Show resolved Hide resolved
Thank you @The1Penguin for the feedback!

Run this in the repl to get fresh test data:

```Haskell
dateNow <- fmap (view _zonedTimeToLocalTime) getZonedTime
tomorrow = (dateNow & (_localDay . gregorian . _ymdDay) %~ (+ 1)) ^. _localDay
runStack $ fetch "21f31565-5c2b-4b47-d2a1-08d558129279" tomorrow
```

Then run the test and adjust the expected data to match the actual data.
This is the backwards way to write tests, but I think it's alright when
it's this easy to see if expectation and actual data matches.
Copy link
Contributor

@The1Penguin The1Penguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@icicel icicel merged commit 67bf6e8 into main Sep 24, 2023
2 checks passed
@icicel icicel deleted the fix/remove-express branch September 24, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kanske ta bort Express??
4 participants