Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature 673 release guide #713

Merged
merged 21 commits into from
Dec 3, 2020
Merged

feature 673 release guide #713

merged 21 commits into from
Dec 3, 2020

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Dec 3, 2020

Pull Request Testing

  • Describe testing already performed for these changes:

    New documentation files only, so no testing is necessary.

  • Recommend testing for the reviewer to perform, including the location of input datasets:

    None

  • Will this PR result in changes to the test suite? [No]

  • After merging, should the reviewer DELETE the feature branch from GitHub? [Yes]

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.

Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how this document is structured. It gives us the ability to reuse common instructions across multiple repos while also providing a clear and consistent way of customizing those instructions when needed for each repo.

I approve these changes and recommend that we continue developing the content with each successive release.

@georgemccabe georgemccabe merged commit 7318a8f into develop Dec 3, 2020
@georgemccabe georgemccabe deleted the feature_673_release_guide branch December 3, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal: Create a METplus "Release Guide" describing how to build releases for the METplus components.
3 participants