Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2666 sonarqube #2784

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Feature #2666 sonarqube #2784

merged 5 commits into from
Nov 13, 2024

Conversation

JohnHalleyGotway
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

    Reviewed my doc-only changes on RTD.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Listing both @jprestop and @georgemccabe but only one review is needed.
    Please review these SonarQube details for my feature_2666_sonarqube branch on RTD for accuracy and clarity.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]
    None needed.

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by [Wed 11/13/24].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

jprestop
jprestop previously approved these changes Nov 13, 2024
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for writing all of this up @JohnHalleyGotway. This is very helpful information. I made a couple of minor suggestions (commas and one slight rewording). I approve this request.

Co-authored-by: Julie Prestopnik <[email protected]>
@JohnHalleyGotway JohnHalleyGotway removed the request for review from georgemccabe November 13, 2024 16:25
@JohnHalleyGotway JohnHalleyGotway merged commit aca38b3 into develop Nov 13, 2024
3 checks passed
@JohnHalleyGotway JohnHalleyGotway deleted the feature_2666_sonarqube branch November 13, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Documentation: Document SonarQube for the METplus components in the Contributor's Guide
2 participants