-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update develop-ref after dtcenter/MET#2524 #2171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and s2s_mjo. ci-run-all-diff
…mpty string. Previously a False default value was logged as set to empty string
…a default value of False
…or this wrapper is optional and different behavior will be executed if no config file is set
…or this wrapper is optional and different behavior will be executed if no config file is set
…le and replace MET_CONFIG_OVERRIDE variable with TC_PAIRS_MATCH_POINTS
…e cases. ci-run-all-diff
* adding new questions section * changing table config #650 * odd section bullets #650 * adding in the rest of the text but not formatted #650 * first attempt at bullet formatting #650 * fixing errors #650 * fixing errors take 2 #650 * fixing errors take 3 #650 * fixing errors take 4 #650 * fixing errors take 5 #650 * Update systemconfiguration.rst Cleaning up "you" and changing to 3rd person. Except where "you" is referenced by a program example #650 * Update systemconfiguration.rst Taking another stab at making the bullets consistent #650 * creating new getting_started file to house Questions to Consider that was removed from the systemconfiguration file. * moving Running METplus into getting_started file and removing it from the systemconfiguration. #650 * updating index to include new Getting Started chapter #650. * updating index to include new Getting Started chapter take 2 #650. * shortening the chapter name to Installation and Configuration #650 * using updated questions #650 * Made a few formatting/wording changes * Removed text * adding flowchart question and adding periods #650 * bolding files #650 * adding changes John O. recommended. #650 * small John O. change #650 * removing duplicate question #650 * fixing question order #650 * fixing typos Tara requested * answering question 2.1.1.7 * adding Use Case Rules link to 2.1.1.7 * adding proper link to the Add Use Cases in the Contributors Guide * trying to get link to work * trying to get link to work take 2 * trying to get link to work take 3 * trying to get link to work take 4 * removing unnecessary link * fixing punctuation Co-authored-by: Julie Prestopnik <[email protected]>
* changes needed to create v5.0 version of metplus_base docker/conda environment * update metplotpy conda env to use python 3.8 and new package list, then test to see if use cases that use that env still work using the .v5 version * turn on use cases that use metplotpy_env to test new conda env * add .v5 to metplotpy conda env to test that environment * removed cartopy from requirements because cartopy may no longer be needed * changed conda environment used for use case * update conda before building environments * updated instructions and scripts to build python environments using Python 3.8.6 for METplus v5 * updated conda env to include .v5 * updated automated test logic to use new .v5 Docker images that use Conda environments built from Python 3.8.6 * rebuilt gempak and gfdl-tracker docker images to use .v5 extension to be consistent in the automation logic and avoid special behavior for those environments * added note to update OS packages to prevent wget certificate errors * renamed variables to be more clear which path they are actually storing * Updated logic to no longer handle gempak and gfdl-tracker envs differently by excluding the version number. Cleaned up logic to add version number extension to conda environment names as needed * updated scripts to create Docker image containing Conda environment for METdataio (renamed from METdatadb) to use in automated tests for v5 * turn off all use cases * turn on use cases that previously failed * turn off use cases tests that passed * turn off all use cases * per #1566, added explicit version numbers for each Python package that is installed in the Docker Conda environments used for the automated tests to ensure that the same environment will be generated even if the default version of the package differs from the env used to create them
… on develop or main_vX.Y branches because I discovered that the commit message from doing a squash and merge in a pull request will contain any keywords used during development
* per #1713, remove setting of METPLOTPY_BASE env var in each use case config file and instead set it in the global config settings for the automated test environment, ci-run-all-cases * per #1713, added instructions to set METPLOTPY_BASE via [user_env_vars] in the default METplus config file upon install if necessary * per #1713, added documentation to describe METPLOTPY_BASE variable that was added to the defaults.conf file
…s done because the value in the TCPairsConfig_wrapped file was TRUE, but the default value in the MET config file is FALSE. Typically if a METplus variable is unset, we do not set any value for the corresponding env var which results in using the value in the default MET config file. Doing this would cause many use cases to change their results unless TC_PAIRS_MATCH_POINTS=True was added to each use case config file. We could do this for our repository, but any use case config files outside of the METplus repo would need to be updated
…es are not set instad of calling sys.exit
… used if the pre-processing steps are needed
* test dropdowns * Update release-notes.rst Attempting to resolve WARNING * testing dropdowns * adding dropdown menus * testing dropdown remove from warning section * dropdown testing * dropdown menu tests * dropdown menus after the warnings section, the dropdown menu only has one space instead of the normal 2 spaces. If it has 2 spaces, it gets sucked into the warning section. * spaces with warning * no spaces for warning * Update release-notes.rst warning note has to be indented 1 space. Originally it was no spaces but then all of the dropdown menus end up in the warning message. If it's 2 spaces, as is normal, then the warning is indented, which is unnecessary. 1 space is slightly indented and keeps the dropdown menus separate. --------- Co-authored-by: jprestop <[email protected]>
Co-authored-by: Tracy Hertneky <[email protected]> Co-authored-by: George McCabe <[email protected]>
Co-authored-by: Giovanni Rosa <[email protected]>
Co-authored-by: j-opatz <[email protected]>
* change PROJECT ASSIGNMENT to CYCLE ASSIGNMENT * change PROJECT ASSIGNMENT to CYCLE ASSIGNMENT * change PROJECT ASSIGNMENT to CYCLE ASSIGNMENT * change PROJECT ASSIGNMENT to CYCLE ASSIGNMENT * change PROJECT ASSIGNMENT to CYCLE ASSIGNMENT * change PROJECT ASSIGNMENT to CYCLE ASSIGNMENT * Added paths to ignore --------- Co-authored-by: jprestop <[email protected]>
…duced by urllib3 (see urllib3/urllib3#2168)
…n or enter branch by hand if branch does not exist in dtcenter/METplus repo, e.g. if updating data for a PR coming from a fork
…e repository and commit sha that triggered the workflow
… release 3.18.0 that does not include docker-compose in the apk repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR dtcenter/MET#2524 for issue dtcenter/MET#2523 changes the order of the dimensions of the NetCDF output files from the TC-RMW tool.
Created by @JohnHalleyGotway