Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature dtcenter/METplus-Internal#32 change SCRUB_STAGING_DIR default and add documentation #1784

Merged
merged 11 commits into from
Sep 8, 2022

Commits on Aug 24, 2022

  1. Per dtcenter/METplus-Internal#32, update logic to compute LOG_TIMESTA…

    …MP from LOG_TIMESTAMP_TEMPLATE and save it in the METplusConfig so it can be referenced by other variables including METPLUS_CONF (final conf file). Removed logic to handle if LOG_METPLUS is unset that uses an old config variable that is not documented or used anywhere
    georgemccabe committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    368ac78 View commit details
    Browse the repository at this point in the history
  2. Per dtcenter/METplus-Internal#32, changed default values for METPLUS_…

    …CONF to include the log timestamp and changed LOG_METPLUS to use LOG_TIMESTAMP instead of LOG_TIMESTAMP_TEMPLATE -- in metplus_config, the formatted log timestamp is substituted in the read of the LOG_METPLUS variable, but it would not be formatted properly in any other use. Formatting the log timestamp and saving it as LOG_TIMESTAMP will make it available to use in other places
    georgemccabe committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    2b144c4 View commit details
    Browse the repository at this point in the history
  3. changed logic to skip metplus final conf so that it will be skipped i…

    …f there is a timestamp included at the end of the filename
    georgemccabe committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    f4d4de0 View commit details
    Browse the repository at this point in the history
  4. per dtcenter/METplus-Internal#32, added default config variable FILE_…

    …LISTS_DIR that includes the log timestamp to prevent issues with multiple runs but still allow users to change the default to remove the timestamp if they desire
    georgemccabe committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    0bf8dcb View commit details
    Browse the repository at this point in the history
  5. added default overrides for METPLUS_CONF and FILE_LISTS_DIR for the c…

    …onfig files that are used to run pytest unit tests and GitHub Actions automated test suite
    georgemccabe committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    eff624d View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Configuration menu
    Copy the full SHA
    87719c6 View commit details
    Browse the repository at this point in the history
  2. per dtcenter/METplus-Internal#32, move SCRUB_STAGING_DIR to defaults.…

    …conf and change default value to True
    georgemccabe committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    ab458fc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dc1ede4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ede8b64 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d1262f4 View commit details
    Browse the repository at this point in the history
  6. override SCRUB_STAGING_DIR for tests so there will be no differences …

    …and the files will be available if needed to debug
    georgemccabe committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    d61a09e View commit details
    Browse the repository at this point in the history