-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 1694 s2s subgroups #1697
Conversation
…dingly, and turned on all s2s use cases to test that they all run successfully after the changes
…ed other METdbLoad use case to see if that fails as well
…g created properly
…ing created properly
…ed from METviewer to METdataio
…dtcenter/metplus-envs:metdataio Docker image
…t METdatadb rename to METdataio, ci-skip-unit-tests
…use case was likely not related, ci-skip-unit-tests
… case test job failed due to an actual failure or due to differences in the output
…vent warning that artifact contains more than 10,000 files. The 2 WeatherRegime use cases produce a lot of output files, so splitting them up should resolve this warning
@@ -42,7 +42,6 @@ one of the following: | |||
|
|||
* air_quality_and_comp | |||
* climate | |||
* convection_allowing_models | |||
* data_assimilation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add in "short_range" to replace the "convection_allowing_models".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are looking at the "before" text. This change is removing convection_allowing_models and adding short_range below.
…ort range in the Verification Datasets section of the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Output from RMM, OMI, blocking, and weather regime match what they were prior to the change, so this looks good on my end. We may want to uncover the settings to avoid overlapping documentation in the future
… the current version of the documentation to match the quick search links from the METplus User's Guide
…e s) to short_range that were missed
… short_range and added note to alert developers that the list of use cases in the script is not maintained and therefore not complete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change over for naming and new s2s categories looks to be all set. Documentation looks correct, and any missed references to convection allowing models at least shouldn't break the documentation.
Co-authored-by: George McCabe <[email protected]> Co-authored-by: Mrinal Biswas <[email protected]> Co-authored-by: Hank Fisher <[email protected]> Co-authored-by: Minna Win <[email protected]> Co-authored-by: bikegeek <[email protected]> Co-authored-by: Christina Kalb <[email protected]> Co-authored-by: Julie Prestopnik <[email protected]> Co-authored-by: johnhg <[email protected]> Co-authored-by: Hank Fisher <[email protected]> Co-authored-by: Mrinal Biswas <[email protected]> Co-authored-by: jprestop <[email protected]> Co-authored-by: j-opatz <[email protected]> Co-authored-by: Kathryn Newman <[email protected]> Co-authored-by: j-opatz <[email protected]> Co-authored-by: Lisa Goodrich <[email protected]> Co-authored-by: Julie Prestopnik <[email protected]> Co-authored-by: Christina Kalb <[email protected]> Co-authored-by: lisagoodrich <[email protected]> Co-authored-by: bikegeek <[email protected]> Co-authored-by: Hank Fisher <[email protected]> Co-authored-by: Christina Kalb <[email protected]> Co-authored-by: Howard Soh <[email protected]> Co-authored-by: Molly Smith <[email protected]> Co-authored-by: hsoh-u <[email protected]>
Change Summary
Pull Request Testing
Ensured all use cases ran successfully in automated tests
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
See above. Diffs will be shown in many use cases because they were renamed/renumbered. The actual output of these use cases should not differ.
Please complete this pull request review by 7/18/2022.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes