feature 1653 develop climo day_interval NA value #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(i.e. GRID_STAT_CLIMO_MEAN_VAR1_NAME). Added function to easily format field info for a single field or list of fields with fewer arguments
…ield_info and can eventually replace it
…ld generate at least 1 command. Example and CyclonePlotter wrappers do not run any shell commands, so they are excluded
… independent and provide reference to that entry instead of duplicating information for each wrapper
…ean/stdev dictionary can be NA or an integer
…stead of just integers
… variables, added tests for all other climo variables
23 tasks
|
Since all tests passed, merging this without review to get 5.0.0-beta1 release created. |
j-opatz
reviewed
Jun 22, 2022
j-opatz
added a commit
that referenced
this pull request
Jul 6, 2022
* fixing typos #1049 * moving blank statistic type from statistics to diagnostics #1049 * Feature 1263 v4.1.0 beta4 (#1277) * update version to note development towards beta5 * fixing errors #1049 * updating table name #1049 * fixing typo #1049 * Feature 934 release stage doc (#1235) * Per #934 add stages of the METplus release cycle. * Per #934, adding link to descriptions of the release cycle in the User's Guide. * Per #934, made corrections * Per #934, changed Beta and Release Candidate (rc) from bold to subsubsections. * Update index.rst Co-authored-by: Julie Prestopnik <[email protected]> * putting both tables into one chapter * removing diagnostics since it's going back into the statistics chapter #1049 * Delete diagnostics_list.rst This table will be added to the statistics page as a separate table. #1049 * test. breaking out directories A-B and C-D #1049 * testing with section names #1049 * alphbetical sections for statistics #1049 * making U-Z statistics list #1049 * alpabetical breaks for diagnostics list #1049 * trying to fix errors #1049 * trying to fix errors take 2 #1049 * trying to fix errors take 3 #1049 * Removed a unnecessary space #1049 * Making all METplus Names CAPITAL LETTERS #1049 * Feature 344 met util refactor (#1292) * removed deprecated sections from config examples * minor change to METplus release guide to add a link to the PDF of the User's Guide instead of downloading it and attaching it to the release * Feature 1285 extract tiles mtd times (#1315) * Feature 896 more met config (#1322) * removed incorrect search keyword * added workflow_dispatch event so workflow can be triggered by an external repository such as MET to test to ensure that changes from that repo will break anything in METplus * added another input argument for workflow_dispatch event * added job with name that shows the event name or the repository name if triggered by an external repository such as MET * GHA: add username that triggered external event to event info job name * added required input argument for external trigger that contains the commit hash of the push event that triggered in the other repo * change event info to show commit hash instead of username that merged the PR * changed input names to match names of event in repository that triggered workflow * feature 1320 OMP_NUM_THREADS (#1338) * Feature 1183 memory documentation (#1340) Co-authored-by: George McCabe <[email protected]> * add email address of user who triggered push event to job name * Feature 1166 series analysis field info (#1353) * Feature 1116 usecase smos (#1348) Co-authored-by: Mrinal Biswas <[email protected]> * turn off new use case from every push * feature 1236 Control Members in EnsembleStat and GenEnsProd (#1357) * added optional argument to change the directory to untar new input data into so the same Dockerfile can be used to add data for other METplus components such as MET * feature 1358 v4.1.0-beta5 release (#1359) * update version for next development cycle * Feature 1216 usecase smap (#1361) * Adding a conf file for SMAP * Adding a directory to host the read file * Removing temp file * Updated the valid dates to match Todd's code * Adding documentation for SMAP case * Updates the valis dates to match Todd's code * Removing a tmp file * Typo in file name * Updating the input RTOFS to have the init time instead of the valid time ii the file name * updated file paths, tesing * updated use case descriptions, rearranged use case group testing * put new use case into its own group so that the diff logic can evaluate marine_and_cryosphere:3. The truth data for 3-4 does not exist yet so the diff fails. Co-authored-by: Mrinal Biswas <[email protected]> Co-authored-by: George McCabe <[email protected]> * updated marine_and_cryo grouping * Feature 1230 stratosphere metrics (#1354) * Initial checkin for Meridial Mean use case * Changed the name and directories * Added some documentation * Fixed config variables * Issue 1230 Stratospheric metrics (zonal/meridional use case) put INPUT_BASE in the user_env_vars so the user doesn't need to set the INPUT_BASE environment in the current working shell * Issue #1230 remove import of metplotpy-this isn't called * Issue #1230_stratosphere_metric Add use case to the list of use cases to be run for testing * Issue 1230 Remove the INPUT_BASE from the user_env_vars section * Issue #1230 redundant files * Issue #1230 redundant files * Issue #1230 redundant files * Issue #120 replace INPUT_BASE with INPUT_FILE_NAME * Issue #1230 remove entry for INPUT_FILE_NAME, this goes in the system.conf * Update all_use_cases.txt Copy and pasted #11 from s2s use case for the Stratosphere use case but forgot to update the index to 12. * Update use_case_groups.json added use case #12 from s2s to test stratosphere use case * Issue #1230 put INPUT_FILE_NAME back under the user_env_vars * Issue #1230 forgot to include the filename * Issue #1230 clean up config file, remove uneccessary comments, group related entries in the user_env_vars * Issue #1230 remove extraneous and incorrect path to the input_filename setting * Removed pingouin dependency * Issue #1230 another cut and paste error fixed for the Stratosphere use case * Issue #1230 type in name, obs_Only should be obsOnly * Issue #1230 added the metdatadb to the env, code imports metdatadb and may require some of these dependencies * issue #1230 removed pingouin dependency from comment to reduce any confusion * issue #1230 turn off the test for the Stratosphere metrics use case * Added use case image Co-authored-by: Hank Fisher <[email protected]> Co-authored-by: Minna Win <[email protected]> Co-authored-by: bikegeek <[email protected]> Co-authored-by: Christina Kalb <[email protected]> * Corrected spelling of occurrence in two places * Fixed misspelling of occurrence * Found and fixed two more misspellings of occurence * Changed version specific information to by X.Y.Z moved text indicating to click save to the bottom of the list. * Feature 1374 python packages (#1378) * Added documentation about updating spreadsheet of Python requirements * Changed references to master_metplus.py to run_metplus.py * Fixed formatting of section with run_metplus.py commands * Updated text for updating the spreadsheet * Removed a newly added section that wasn't needed Co-authored-by: Julie Prestopnik <[email protected]> * feature 1368 PCPCombine use zero accum (#1381) * feature 1369 grid_weight_flag in EnsembleStat (#1379) * Per #1356, change how wrappers create instances of other wrappers to ensure that config settings for the created instance do not change values in METplusConfig used by the rest of the wrappers, ci-run-all-diff * Per #1356, remove config_overrides functionality in favor of using instances -- this prevents the issue where overrides for a given tool affect the global config settings. it also forces the configs to override for an instance to be put into another config section so that it will be available in the final conf, ci-run-all-diff * Per #1356, update documentation to reflect changes * Per #1356, fixed unit test to no longer use deprecated approach to overriding config variables * feature 1247 climatology settings (#1385) * feature 1356 isolate config (#1386) * Feature 675 Continuous Integration Documentation (#1409) Co-authored-by: johnhg <[email protected]> * feature 1382 Filename templates in MODEL (#1414) * Feature 1289 explicit file list (#1387) * Per PR #1387 review, fix typo * Bugfix 1421 EnsembleStat use fcst fields in ens dictionary if ens is unset (#1422) * fixed missing path change for docker file path * removed variables that are not used * Feature 1408 use case ptype (#1425) * adding imagery, config file, updating internal tests * updated lists, auto testing * corrected old reference * Update use_case_groups.json * only trigger testing workflow for pull requests that are going into develop or main_* branches * Feature 1371 blocking wr (#1426) * turn off use cases for push events * Feature 1392 climo_cdf.direct_prob and SeriesAnalysis (#1396) * Changed event triggering rules for documentation workflow so that it will run for pull requests even if no files in the docs directory have changed. A recent pull request passed but develop failed after it was approved because files that were referenced in the use case documentation files had been deleted as part of the PR. * feature 1273 TCGen -edeck and -shape (#1424) * Feature 966 Fix mask.poly logic (#1430) * Feature 1030 total seconds documentation (#1428) Co-authored-by: George McCabe <[email protected]> * Update UserScript_fcstGFS_obsERA_Blocking.py * Update UserScript_fcstGFS_obsERA_Blocking.py * Update UserScript_fcstGFS_obsERA_Blocking.py * Update UserScript_obsERA_obsOnly_Blocking.py * Update UserScript_fcstGFS_obsERA_WeatherRegime.py * Update UserScript_obsERA_obsOnly_WeatherRegime.py * Update UserScript_obsERA_obsOnly_WeatherRegime.py * Update UserScript_fcstGFS_obsERA_Blocking.py * Update UserScript_fcstGFS_obsERA_WeatherRegime.py * Update UserScript_obsERA_obsOnly_Blocking.py * Update UserScript_obsERA_obsOnly_WeatherRegime.py * Update UserScript_fcstGFS_obsERA_Blocking.py * Update UserScript_fcstGFS_obsERA_WeatherRegime.py * Update UserScript_obsERA_obsOnly_Blocking.py * Update UserScript_obsERA_obsOnly_WeatherRegime.py * Update UserScript_fcstGFS_obsERA_Blocking.py * Update UserScript_fcstGFS_obsERA_WeatherRegime.py * Update UserScript_fcstGFS_obsERA_WeatherRegime.py * Update UserScript_fcstGFS_obsERA_Blocking.py * Update UserScript_obsERA_obsOnly_Blocking.py * Update UserScript_obsERA_obsOnly_WeatherRegime.py * get branch name in job controls job * replace logic to update input data volumes with call to dtcenter/metplus-action-data-update action * feature 1431 remove obs_prepbufr_map (#1433) * Per #675, added images and updated content * added statsmodel package to metplotpy docker conda environment * Added fcst_file_type to two wrappers (#1437) Co-authored-by: Hank Fisher <[email protected]> Co-authored-by: George McCabe <[email protected]> * added release notes for tasks that have already been completed for beta6 * updated env var for METplotpy base to match changes made to the METplotpy repository * Updated METplotpy base env var to preemptively match changes from PR dtcenter/METplotpy#197. Once that PR is merged into develop, a test workflow will run that should fix this issue. * removed commented code that is no longer used * update the instructions for updating test input data to ensure volume_mount_directories file is updated in the upcoming version directory, i.e. v4.1, so that the Docker data volumes from the release will be created properly * removed duplicate script * updated script to copy volume_mount_directories file into new METplus version directory * added logic to skip files that are temporary copies of tar files that should not be added to new version directory * updated release guide instructions for creating METplus data directory for next development cycle * Feature 911 tc trackint (#1439) Co-authored-by: Mrinal Biswas <[email protected]> Co-authored-by: George McCabe <[email protected]> * added new use cases that are currently being reviewed to release notes * updated event info in contributor's guide * Feature 626 fix hovmoeller documentation (#1444) * Update UserScript_obsPrecip_obsOnly_Hovmoeller.py replace hovmoeller_diagram.conf with UserScript_obsPrecip_obsOnly_Hovmoeller.conf * Update UserScript_obsPrecip_obsOnly_Hovmoeller.py Removed a typo: UserScript This uses data from... Now: This uses data from... * Update UserScript_obsPrecip_obsOnly_Hovmoeller.py * Modified the PR template to add review of the source issue metadata ci-skip-all * feature_1403_python_components_table (#1446) * creating new METplus Components Python Requirements * adding a return to test * testing use case links * testing use case links #2 * testing use case links #3 * testing use case links #4 * Filling in some use cases * fixing indentation #1403 * fixing indentation #1403 take 2 * fixing indentation #1403 take 3 * cleaning up anything after # in the links #1403 * entries thru D #1403 * entries thru H #1403 * fixing indents #1403 * fixing indents #1403 take 2 * fixing web name #1403 * entries thru L #1403 * entry matplotlib #1403 * entry matplotlib #1403 marking duplicate names * entry metcalcpy #1403 * entry metcalcpy fix indents #1403 * entry matplotlib #1403 fixing duplicate names * entry metplotpy #1403 * entry metplotpy #1403 marking duplicate names * entry metplotpy #1403 fixing * entry thru ps #1403 * double names #1403 * character fix #1403 * adding in missing links #1403 * thru pyproj #1403 * problem with line 353 #1403 * thru pyproj #1403 typos * more duplicate names #1403 * line break #1403 * loose ends #1403 * adding >= to some of the versions #1403 * adding name to the Use Cases to avoid duplicate naming issues TEST #1403 * adding name to the Use Cases to avoid duplicate naming issues thru pyproj #1403 * adding thru pyresample #1403 * fixing pyresample typo #1403 * adding thru scikit-image #1403 * fixing line breaks#1403 * web links thru scikit-learn #1403 * web links thru scipy #1403 * web links thru sklearn #1403 * Duplicate web names. temp. fix #1403 * Duplicate web names fixed #1403 * Duplicate web names fixing #3 #1403 * Duplicate web names fixing #4 #1403 * Duplicate web names fixing #5 #1403 * table end #1403 * table loose ends #1403 * Removed unnecessary comma * table loose ends after pull request #1403 * Minor modifications to METplus Component column * Changed description of pyproj * Added link for last referenced use case * Attempting to fix doc warning Co-authored-by: jprestop <[email protected]> * Feature 1318 usecase aviso (#1440) * Correct small typo. * Update pull_request_template.md * Added files for ReadTheDocs (#864) * Updated documentation links for ReadtheDocs * Update pull_request_template.md Added entry for completion date for pull request review. * Adding python embedding script to read AVISO, RTOFS, HYCOM and OSTIA data * Updated the script - working but only RMSE values match * Adding documentation for the AVISO case * Adding a conf file for the AVISO case * Updates to the codel to include model3, obs, climo3 but also has many extra print statements, netcdf output files which needs to be cleaned * Cleaning up the conf file and adding SAL1L2 to get the model_climo sdev and obs_climo sdev * Updating the file to fix the standard names and add the model3, climo3 and obs3 * Updating the file to fix the standard names and add the model3, climo3 and obs3 * Adding an image to the use case. Image Courtesy: EMC/NOAA website * added to use case list * updated case description * removed merge issues * caught second docs issue * removed other doc merge issues, turned off auto test * more merge comments sneaking in Co-authored-by: johnhg <[email protected]> Co-authored-by: jprestop <[email protected]> Co-authored-by: Mrinal Biswas <[email protected]> * Revert "Feature 1318 usecase aviso (#1440)" (#1459) This reverts commit d3021de. * Feature 1449 v4.1.0 beta6 (#1461) * Per #1449, updated version as specified in the Release Guide * Per #1449, updated release notes * Updated release date for beta6 release Co-authored-by: Julie Prestopnik <[email protected]> * updated version number after beta release * Feature 1318 usecase aviso attempt 2 (#1473) Co-authored-by: johnhg <[email protected]> Co-authored-by: jprestop <[email protected]> Co-authored-by: Mrinal Biswas <[email protected]> Co-authored-by: j-opatz <[email protected]> * error if no input template is set for GridDiag wrapper * added comment for new logic, ci-run-diff * updated old section name to config, ci-run-all-diff * fixed bug with replacing wildcard characters with 'all' in output file paths * Revert "fixed bug with replacing wildcard characters with 'all' in output file paths" This reverts commit c11711e. * fixed bug with replacing wildcard characters with 'all' in output file paths, ci-run-all-diff * feature 1102 -out for TCStat and StatAnalysis (#1477) * feature 1464 EnsembleStat probabilistic additions (#1479) * feature 1445 normalize in GenEnsProd (#1478) * added logic to add quotes around grid value if they are not set in conf variable value, moved error check for unset grid to init step, ci-run-all-diff * bugfix 1486 PB2NC file window variables not read (#1487) * added build arg to override MET DockerHub repository so development version tests can use dtcenter/met-dev:develop * set MET DockerHub repo based on develop or stable version of METplus * run diff logic for push events to develop and main_v* branches so we can catch if changes to external repositories caused differences in the output * do not run diff logic on main_v* and develop branch push events -- diff logic is already running when external repository triggers workflow, which is what we need to test with the diff logic * Added description for Use Cases * updated script to set up new release input data directories -- use real path for all symbolic links for consistency, added usage statement * changed logic to error if new version directory to create already exists at all -- previous logic only errors if directory is not empty * Changed all filename template tags for datetime objects (init/valid/da_init/etc.) to use %H instead of %2H. We discovered that Python 3.6.8 interprets %2H as the same as %H (correctly substituting the hour), however Python 3.8.8 interprets %2H as 2H. The number in between the % and letter is not supported by strftime so it is not valid for these datetime values. The logic to zero-pad using this notation was written in the METplus string substitution logic and only applies to lead and level template tags. ci-run-all-diff * feature 1274 TCGen use case using -shape/-genesis (#1492) Co-authored-by: Kathryn Newman <[email protected]> Co-authored-by: j-opatz <[email protected]> * feature 1490 Python Embedding for Point Observations (#1491) * update use case groupings for automated tests * removed extra comma typo, ci-run-all-diff * added missing characters in commmands * Feature 1403 python components table (#1497) Co-authored-by: Lisa Goodrich <[email protected]> Co-authored-by: Julie Prestopnik <[email protected]> * testing new statistics provided by Tara #1049 * testing new statistics #2 #1049 * New statistics from Tara #1049 * New statistics from Tara small corrections #1049 * New statistics from Tara small corrections #2 #1049 * New statistics from Tara small moving to Diagnostics table #1049 * Fixing space-time, like that's possible #1049 * Fixing spacing #1049 * feature 1471 fix current field info in output_prefix (#1500) * Feature 1503 v4.1.0 rc1 (#1504) * update version after rc1 release to reflect development towards 4.1.0 release * Corrected documentation title name * bugfix 1486 pb2nc window variables (#1507) * feature 1443 document probabilistic field settings (#1508) Co-authored-by: johnhg <[email protected]> * feature 943 document referencing current level (#1509) * feature 1510 v4.1.0 Release (#1511) * updated release guide to reflect updated process to trigger reference branch GHA workflow for an official release * update version to reflect development towards 5.0.0-beta1 release * Feature 673 MET (#1517) * set MET docker repo to dtcenter/met if forcing a specific MET tag to use since that is where the stable release versions are stored on DockerHub * pass variable to tell docker build script that an external workflow triggered the run and use -lite if so to ensure that MET docker image that was created by the triggering MET workflow is used * echo output variables from job control job so they can be reviewed in the GHA log output * minor fix for consistency in logs, ci-skip-all * Feature 1399 usecase cable (#1538) * Adding initial code to read AOML Cable Transport and RTOFS cable transport variables * Updating the conf file (no stat analysis yet) and updates to the read file * Updating the conf file to add STAT_ANALYSIS * Updates to the code- adding stats * Updated code--runs now but needs to follow User Script conventions * Changed directory name based on MET conventions * Updating the read file and adding a conf file * Added logic to count the number of directories in the RTOFS dir * Updated to run with UserScript conf * update version for official release * Adding a yaml file to specify start_date * Added the yaml file and cleaned up the conf file * Added logic to read the yaml file, cleaned up the script * Updating the confile to add output dir, input template and clean up * Removing yaml, getting vDate from conf file, adding output file * Adding the doc file for the cable use case * Adding image courtesy NOAA * Adding more documentation * Adding more info * Updated docs * Correcting the python embedding script * Updating to see if the error goes away..no clue * Fixing the doc error * modifed docs, testing * updated permissions for script * turned off always testing * Updated version number * Update use_case_groups.json * Removed erroneous file * Apply suggestions from code review * Update .github/parm/use_case_groups.json Co-authored-by: George McCabe <[email protected]> * Update docs/use_cases/model_applications/marine_and_cryosphere/UserScript_fcstRTOFS_obsAOML_calcTransport.py Co-authored-by: George McCabe <[email protected]> * Update docs/use_cases/model_applications/marine_and_cryosphere/UserScript_fcstRTOFS_obsAOML_calcTransport.py Co-authored-by: George McCabe <[email protected]> * Update docs/use_cases/model_applications/marine_and_cryosphere/UserScript_fcstRTOFS_obsAOML_calcTransport.py Co-authored-by: George McCabe <[email protected]> Co-authored-by: Mrinal Biswas <[email protected]> Co-authored-by: George McCabe <[email protected]> * Update UserScript_fcstGFS_obsERA_WeatherRegime.conf Fixed a title typo * Feature component links (#1518) * Feature 770 3rd person (#1564) * changing from 2nd to 3rd person and fixing some spacing #770 * missed we and corrected #770 * typos, spacing etc #770 * spelling, italics and bolding #770 * removing you changing to 3rd person #770 * changing to 3rd person #770 * 3rd person already done. Fixing formatting, typos etc. #770 * 3rd person already done. Fixing formatting #770 * changing to 3rd person, fixing typos, spacing, etc. #770 * changing to 3rd person, fixing typos, grammar and punctuation. #770 * google doc corrections. #770 * clean up #770 * removing | #770 * typo #770 * Fixing TOC and coding block #770 * fixing note #770 * one 3rd person fix. Updating bolding and italics for file names and directories #770 * Modified Python Code Analyis Tools * Modified Python Code Analyis Tools * Removed link for PROCESS_LIST. If we can't have an internal link, we do not want one in this case. * fixing space #770 * fixing conflict #2 #770 * fixing typos #770 * fixing typos #2 #770 * directory formatting #2 #770 * Changed sub process to subprocess * Modified usage of user because this text is for developers. Made other minor changes. Co-authored-by: Julie Prestopnik <[email protected]> * bugfix 1555 develop clear args properly (#1562) * Fixed bug in classification text file (#1568) * bugfix 1534 develop fix removal of semi-colon at end of list (#1535) * fixed typo missed in #1477 * feature 33 (internal) disable UserScript wrapper (#1607) * METplus-Internal #14 Initial release * METplus-Internal #16 initial release for python scanning * METplus-Internal #17 Disable SonarQube related path for Docker * change Linked issue/Development issue ci-skip-all * change Linked issue/Development issue ci-skip-all * change Linked issue/Development issue ci-skip-all * change Linked issue/Development issue ci-skip-all * change Linked issue/Development issue * Updated METexpress release guide to reflect new use of github * added section for RAL machines * Fix location of VERSION file * Hofix for the develop branch to correct typo in the internal_tests/scanning/sonarqube directory name. * install requests python package in Docker image used in run_tests custom action because it appears to no longer be available in python3 that comes with alpine:latest (latest was recently updated to 3.16.0), ci-run-all-cases * test using specific version of alpine Docker image to see if the latest version broke the automation logic, ci-run-all-cases * Revert "test using specific version of alpine Docker image to see if the latest version broke the automation logic, ci-run-all-cases" This reverts commit e417803. * Change Linked issue/Development issue ci-skip-all * Feature 1627 release guide (#1630) * Added instructions for updating the Coordinated METplus X.Y release section on the DTC website * Made some wording changes. * Update docs/Release_Guide/release_steps/common/update_dtc_website.rst Co-authored-by: johnhg <[email protected]> * Update docs/Release_Guide/release_steps/common/update_dtc_website.rst Co-authored-by: johnhg <[email protected]> * Update docs/Release_Guide/release_steps/common/update_dtc_website.rst Co-authored-by: johnhg <[email protected]> * Update docs/Release_Guide/release_steps/common/update_dtc_website.rst Co-authored-by: johnhg <[email protected]> * Update docs/Release_Guide/release_steps/common/update_dtc_website.rst Co-authored-by: johnhg <[email protected]> * Update docs/Release_Guide/release_steps/common/update_dtc_website.rst Co-authored-by: johnhg <[email protected]> * Update docs/Release_Guide/release_steps/common/update_dtc_website.rst Co-authored-by: johnhg <[email protected]> Co-authored-by: johnhg <[email protected]> * feature 1608 METDbLoad read MODE/MTD txt files (#1628) * #1614 Cycloneplotter METplotlibDeprecationWarning observed in Matplotlib versions above 3.2 (#1621) * bugfix #1641 develop StatAnalysis list format (#1646) * feature 1586 added wrapper-specific version of probabilistic config variables (#1644) * Feature 1603 met data db mode (#1649) Co-authored-by: George McCabe <[email protected]> Co-authored-by: Christina Kalb <[email protected]> * Feature 1159 discussions (#1634) * Initial documentation for user support * Modified to try to resolve documentation errors * Update wording and formatting * Attempt to fix formatting problem * Modified and added content * Trying out new formatting * Trying out new formatting * Made suggested changes from John. * Added QC_FLAGS and ADP to the arguments correctly (#1654) Co-authored-by: Hank Fisher <[email protected]> * Updating order to remove data before creating new tarfile * feature 1585 multi-variate MODE support (#1665) * Feature 1650 update hovmoeller (#1666) Co-authored-by: George McCabe <[email protected]> * feature 1599 set climo_mean/stdev using VAR<n> variable syntax (#1658) * feature 1653 develop climo day_interval NA value (#1671) * moved logic to handle climo_mean/stdev dictionaries into met_config utility * moved constant variable to constants and made name uppercase * per #1599, added logic to read VAR<n> variables for climo_mean/stdev (i.e. GRID_STAT_CLIMO_MEAN_VAR1_NAME). Added function to easily format field info for a single field or list of fields with fewer arguments * added function to format field info that is easier to call than get_field_info and can eventually replace it * added line breaks to match pep8 standards, ci-run-all-diff * per 1599, added documentation for new config variables * replaced calls to get_field_info with format_field_info since it is much simpler * fixed bug where field list is never returned from function call * removed whitespace * modified logic to report an error if no commands were run at all * only report an error if the process list contains a wrapper that should generate at least 1 command. Example and CyclonePlotter wrappers do not run any shell commands, so they are excluded * per feedback in PR #1658 review, added glossary entry that is wrapper independent and provide reference to that entry instead of duplicating information for each wrapper * per #1653, add unit tests to check that day_interval value of climo_mean/stdev dictionary can be NA or an integer * per #1653, modified function to read climo variables to support NA instead of just integers * per #1653, updated unit tests to test both climo_mean and climo_stdev variables, added tests for all other climo variables * feature #1673 5.0.0-beta1 release (#1674) Co-authored-by: jprestop <[email protected]> * update version for development towards 5.0.0-beta2 * added logic to switch DockerHub repo used to obtain MET to use dtcenter/met-dev if the tag is develop, otherwise use dtcenter/met * Updates to the release instructions based on MET version 11.0.0-beta1. After restructuring the repo, remove the 'met/' prefix from some paths. Also, remove the attach_release_tarfile.rst instructions since that step is no longer required. Technically, its still needed for version 10 bugfix releases, but just removing it now is simpler. * changed version back to fix release * changed version to show development towards 5.0.0-beta2 release after release was created * Feature 1531 use case CFSv2 s2s (#1587) * added documentation * added pic, config file, more documentation * modified config file, added to internal tests * attempt to correct docs error * added new tool-specific probability feature * Updated run option in json file Co-authored-by: Lisa Goodrich <[email protected]> Co-authored-by: George McCabe <[email protected]> Co-authored-by: jprestop <[email protected]> Co-authored-by: Julie Prestopnik <[email protected]> Co-authored-by: lisagoodrich <[email protected]> Co-authored-by: Mrinal Biswas <[email protected]> Co-authored-by: bikegeek <[email protected]> Co-authored-by: Hank Fisher <[email protected]> Co-authored-by: Hank Fisher <[email protected]> Co-authored-by: Minna Win <[email protected]> Co-authored-by: bikegeek <[email protected]> Co-authored-by: Christina Kalb <[email protected]> Co-authored-by: johnhg <[email protected]> Co-authored-by: Christina Kalb <[email protected]> Co-authored-by: Hank Fisher <[email protected]> Co-authored-by: Mrinal Biswas <[email protected]> Co-authored-by: Kathryn Newman <[email protected]> Co-authored-by: Howard Soh <[email protected]> Co-authored-by: Molly Smith <[email protected]> Co-authored-by: hsoh-u <[email protected]> Co-authored-by: Christina Kalb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Added unit tests to ensure NA and integers can be set for day_interval
Verify all tests pass
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
Just new unit tests added, all tests should still pass
Please complete this pull request review by 6/22/2022.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes