-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update develop-ref after #1187 #1196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on web server so develop-ref can check for new develop data
… dictionaries in GridStat (#858)
…ip instead of custom version, added info to contrib guide about CI
Co-authored-by: George McCabe <[email protected]>
* Added section for ReadTheDocs, added basic info about the Release Guide and Verification Datasets Guide, but more information on those needs to be added later * Added information about the various versions available in the documentation * Updated the ReadTheDocs section with information on hidden branches and how to access them; Modified dtcenter.github.io references * Added section to add_use_case.rst about Accessing the Documentation and modified documentation.rst to indicate the docs can still be built manually * Modified format of list * Modified formatting * Changed GitHub Pages links to Read the Docs links * Modified formatting * Fixed typo * Updated Release Guide for Read The Docs * Took out duplicate data and consolidated sections * Update docs/Contributors_Guide/add_use_case.rst Removed sentence Co-authored-by: George McCabe <[email protected]> * Update docs/Contributors_Guide/add_use_case.rst Fixed typo Co-authored-by: George McCabe <[email protected]> * Update docs/Contributors_Guide/add_use_case.rst Removed end of previously removed sentence. Co-authored-by: George McCabe <[email protected]> Co-authored-by: George McCabe <[email protected]>
…push this change to all the METplus repos.
…ed to all the METplus-related repos.
Co-authored-by: George McCabe <[email protected]>
Co-authored-by: johnhg <[email protected]> Co-authored-by: George McCabe <[email protected]>
Co-authored-by: George McCabe <[email protected]>
Co-authored-by: George McCabe <[email protected]>
Co-authored-by: George McCabe <[email protected]>
* Moved create_release_extra.rst into the release_steps area as all components except for METplus use the same file; Added instructions to update_dtc_website.rst * Removed text that was not supposed to be there. * Update docs/Release_Guide/release_steps/common/update_dtc_website.rst Co-authored-by: johnhg <[email protected]> * Update docs/Release_Guide/release_steps/common/update_dtc_website.rst Co-authored-by: johnhg <[email protected]> * Update docs/Release_Guide/release_steps/common/update_dtc_website.rst Co-authored-by: johnhg <[email protected]> * Removed specific versions of update_dtc_website since they did not differ from the version in release_steps * Added variable - otherWebsiteUpdates - and its value. Co-authored-by: Julie Prestopnik <[email protected]> Co-authored-by: johnhg <[email protected]>
…a release note step about formatting major/important changes in bold.
* Per #1067, modified installation instructions and system configuration to point to installation instructions for MET * removed RTD python package requirements since they are already installed by RTD - fixes issue where bulleted lists bullets disappeared Co-authored-by: Julie Prestopnik <[email protected]> Co-authored-by: George McCabe <[email protected]>
…e update_release_notes files
* removed config variable that is no longer used/needed * cleaned up functions that handle setting CURRENT_[FCST/OBS]_[NAME/LEVEL] * clean up * expand path of config argument to run_metplus.py for easier debugging * removed redundant logic and added comments * cleanup * added logic to move config variables that are runtime specific to a [runtime] section in the final conf that is written after the run completes * changed how config arguments are read so that order that arguments are found is preserved instead of setting explicit overrides at the end * minor change to trigger build, ci-run-all-cases * rearranged logic to save list of config inputs with full paths for easier debugging * move all config vars that start with LOG or end with BASE to runtime section * remove vars that start with CURRENT from final conf * removed confusing logic allowing override of parm base and cleaned up logging to be easier to read/understand * added METPLUS_PARM_BASE env var logic back * added old vs. new default value mismatch info for pb_report_type in PB2NC config file * renamed config var name * use PARM_BASE instead of METPLUS_BASE/parm since it will still be set * use develop version of METviewer docker image (may need to make this configurable in testing.yml in the future) * run cyclone plotter use case to test that new conda environment in docker image now contains missing cartopy map files * added dockerfile to copy cartopy shape files into run image if cartopy is listed as dependencies * download script used to download cartopy shape files and run it * added copy of conda environment * added logic to download cartopy shape files for metplotpy environment * added cartopy dependency to use cases so the shapefiles are copied into run environment * trigger 1 use case that uses metplotpy_env to test cartopy shapefiles are found properly * added instructions to create weatherregime environment that was missing * cleaned up list of packages used * removed extra use case group used for testing * removed netcdf package from env because it is already installed and version number was causing a conflict * added cartopy shapefile copy to use case that needs it * download cartopy shape files for weatherregime python environment because files were not found from base env (metplotpy) * removed debug message that fills up log files with info that is not very useful * updated input directories to use _WeatherRegime directory instead of _Blocking * updated location of input data that was not found in UserScript_fcstGFS_obsERA_WeatherRegime * updated readme with info on how to install metplotpy/metcalcpy in conda environments * added 3rd group of cartopy shapefiles to download because they are used in weatherregime use cases * try using cartopy download script from forked repo that has missing shapefile zip file added * updated input paths to match new data locations
Co-authored-by: George McCabe <[email protected]>
* files for new use case * added new use case and mod files * upping verbosity for debug * more debugging * spelling fix * testing for climo issues * readded climo, changed python3 call in script * skip docker pull because docker create command will pull if needed, print full name of data volume used for easier debugging, no longer pass docker create command output to /dev/null because logic is no longer called from shell script (previously value was passed to script via std out so any logging info would be added to content) * moved new use case to its own section for testing * fixed typo * added PyEmbedIngest to process fcst/obs/climo data and read files into grid_stat to prevent out-of-memory errors * refactored script to try to reduce the amount of unnecessary memory the script uses * created config file to use PyEmbedIngest so use case can run as is on a machine with enough memory and run a modified version to work with the automated tests * removed use case from test suite because it uses more memory than the docker environment has available * removed old info * rearranged variables for readability, removed commented out variables Co-authored-by: George McCabe <[email protected]>
* updated file names for use case * updated documentation for renaming, changing data * Update docs/Contributors_Guide/add_use_case.rst * split section into 2 sections for clarity * added info about removing old data from sample input data, added info about conda environments used for running use cases and automated tests, added text to make instructions more clear if one of two commands should be run * added missing parenthesis Co-authored-by: George McCabe <[email protected]>
need to update reference after renaming a use case, affecting the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1187
Renamed use case, thus affecting the automated testing results. First time updating the ref, so also utilizing the contributor's guide for review.