Improve logic of TCPairs wrapper #749
Labels
component: python wrapper
priority: blocker
Blocker
priority: medium
Medium Priority
reporting: DTC NOAA R2O
NOAA Research to Operations DTC Project
requestor: NCAR
National Center for Atmospheric Research
requestor: NOAA/EMC
NOAA Environmental Modeling Center
required: FOR DEVELOPMENT RELEASE
Required to be completed in the development release for the assigned project
type: enhancement
Improve something that it is currently doing
Milestone
There are two main things that could be improved in this wrapper.
Currently the wrapper passes in the full list of cyclones to process from the METplus config for every run. This works fine if the input files are sorted by cyclone since the input file contains only that cyclone. If the input file contains many cyclones and a list of cyclones are specified in the METplus config, the wrapper will loop over these values and process once for each. The same input file is read and the output files contain the cyclone in the filename (if included in the template), but each file will contain all cyclones listed in the config file.
If we are looping over a list of cyclones and processing once for each, the environment variable CYCLONE should only contain the current cyclone being processed, not the full list of cyclones.
If no cyclones are specified in the METplus config, all of the available cyclones will be processed. However, if the cyclone template is not specified in the input file template, the output file will contain * as the cyclone value. If * is set for the cyclone value in this case, it should be replaced with "all" or something similar to avoid created a problematic filename.
Describe the Enhancement
See above
Time Estimate
1 day
Sub-Issues
Consider breaking the enhancement down into sub-issues.
Relevant Deadlines
None
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
Labels
Projects and Milestone
Define Related Issue(s)
Consider the impact to the other METplus components.
Enhancement Checklist
See the METplus Workflow for details.
Branch name:
feature_<Issue Number>_<Description>
Pull request:
feature <Issue Number> <Description>
Select: Reviewer(s), Project(s), Milestone, and Linked issues
The text was updated successfully, but these errors were encountered: