Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SeriesAnalysis - add support for setting mask dictionary #1926

Closed
10 of 22 tasks
georgemccabe opened this issue Nov 9, 2022 · 0 comments · Fixed by #1932
Closed
10 of 22 tasks

SeriesAnalysis - add support for setting mask dictionary #1926

georgemccabe opened this issue Nov 9, 2022 · 0 comments · Fixed by #1932
Assignees
Labels
component: python wrapper METplus: Configuration priority: medium Medium Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: UK Met Office United Kingdom Met Office type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

Currently the mask dictionary can only be set in a METplus config file using SERIES_ANALYSIS_MET_CONFIG_OVERRIDES. We should support setting it directly.

Describe the Enhancement

Add support for using SERIES_ANALYSIS_MASK_GRID (string) and SERIES_ANALYSIS_MASK_POLY (string) to set mask.grid and mask.poly in SeriesAnalysis wrapper.

Time Estimate

<1 day

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

None

Funding Source

None

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing component: python wrapper priority: medium Medium Priority requestor: UK Met Office United Kingdom Met Office METplus: Configuration labels Nov 9, 2022
@georgemccabe georgemccabe added this to the METplus-5.0.0 milestone Nov 9, 2022
@georgemccabe georgemccabe self-assigned this Nov 9, 2022
@georgemccabe georgemccabe moved this from Todo to In Progress in METplus-Wrappers-5.0.0-beta5 (11/17/22) Nov 9, 2022
@georgemccabe georgemccabe linked a pull request Nov 11, 2022 that will close this issue
14 tasks
Repository owner moved this from In Progress to Done in METplus-Wrappers-5.0.0-beta5 (11/17/22) Nov 17, 2022
@TaraJensen TaraJensen added the reporting: DTC NOAA R2O NOAA Research to Operations DTC Project label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: python wrapper METplus: Configuration priority: medium Medium Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: UK Met Office United Kingdom Met Office type: enhancement Improve something that it is currently doing
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants