Skip to content

Commit

Permalink
Feature #2622 forecast climatology (#2696)
Browse files Browse the repository at this point in the history
* remove support for old environment variables CLIMO_MEAN_FILE and CLIMO_STDEV_FILE that were used in METplus versions earlier than v4.0.0

* fixed SonarQube bugs

* add better error checking for DockerHub queries that occasionally fail in GHA

* update pycharm files

* per #2622, support setting climo_mean and climo_stdev dictionary values inside fcst and obs dictionaries for grid_stat, ensemble_stat, point_stat, and series_analysis. Quietly add support for setting climo dictionaries inside the ens dictionary for gen_ens_prod -- this support is not needed because there is only 1 dictionary that may contain the climo dicts, but adding support for completeness so it can be assumed that {APP_NAME}_{DICT}_{SUBDICT}_{VAR} is supported, e.g. GEN_ENS_PROD_ENS_CLIMO_MEAN_REGRID_METHOD

* turn on use cases that started failing from MET changes

* turn off all use cases from push events 

* reorder assert so that expected vs. actual in PyCharm diff are accurate

* remove commented code

* added unit tests for climo VAR<n> variables that were missing

* add VAR<n> variables used to specify climo_mean/stdev field values
  • Loading branch information
georgemccabe authored Sep 24, 2024
1 parent bf9a134 commit bfd932d
Show file tree
Hide file tree
Showing 33 changed files with 2,787 additions and 57 deletions.
7 changes: 5 additions & 2 deletions .github/jobs/docker_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,11 @@ def docker_get_volumes_last_updated(current_branch):
dockerhub_url = get_dockerhub_url(current_branch)
dockerhub_request = requests.get(dockerhub_url, timeout=90)
if dockerhub_request.status_code != 200:
print(f"Could not find DockerHub URL: {dockerhub_url}")
return None
print(f"Retrying DockerHub request: {dockerhub_url}")
dockerhub_request = requests.get(dockerhub_url, timeout=60)
if dockerhub_request.status_code != 200:
print(f"Could not query DockerHub URL: {dockerhub_url}")
return None

# get version number to search for if main_vX.Y branch
if current_branch.startswith('main_v'):
Expand Down
4 changes: 2 additions & 2 deletions .github/parm/use_case_groups.json
Original file line number Diff line number Diff line change
Expand Up @@ -198,12 +198,12 @@
{
"category": "s2s_mid_lat",
"index_list": "0-2",
"run": true
"run": false
},
{
"category": "s2s_mid_lat",
"index_list": "3",
"run": true
"run": false
},
{
"category": "s2s_mjo",
Expand Down
7 changes: 6 additions & 1 deletion .idea/METplus.iml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions .idea/modules.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit bfd932d

Please sign in to comment.