Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user execute permissions to compile script - develop #2739

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Nov 16, 2023

This allows the compile script to run without having to change the file permissions first.

If desired I can create a PR for main_v11.1 and update the instructions on the MET Download page to remove the chmod command that is no longer necessary.

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

Pull Request Testing

  • Describe testing already performed for these changes:

Ran compile script from cloned repo and confirmed it can be executed without changing permissions.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Both reviewers: Consider any issues this change could create.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [N/A]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

  • Please complete this pull request review by 11/20/2023.

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected. (No issue created)
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve. Changing permissions on this script is fine with me.

As for whether or not you modify main_v11.1 and update the website instructions, I defer to you. If it's easier to do that now while you're thinking of it, go ahead. If you'd prefer to update those instructions after the MET-12.0.0 release (or perhaps never remember to) that's fine too.

@georgemccabe georgemccabe merged commit 62c3dea into develop Nov 16, 2023
34 checks passed
@georgemccabe georgemccabe deleted the feature_compile_script_exe branch November 16, 2023 17:48
@JohnHalleyGotway JohnHalleyGotway removed the request for review from jprestop November 16, 2023 17:59
@jprestop
Copy link
Collaborator

jprestop commented Nov 16, 2023

@georgemccabe I just ran the following:

wget https://raw.githubusercontent.com/dtcenter/MET/develop/internal/scripts/installation/compile_MET_all.sh

but the permissions are not executable when I look at what I downloaded:

-rw-rw-r-- 1 jpresto staff 29157 Nov 16 11:31 compile_MET_all.sh

@georgemccabe
Copy link
Collaborator Author

@jprestop , thanks for testing that. That is interesting that is doesn't have the same permissions when you download the file as when you obtain it from the cloned repository. I'll revert the changes on the download page. I don't think it's necessary to revert these commits, as it will save us a step if we obtain the script from GitHub. What do you think?

@jprestop
Copy link
Collaborator

@georgemccabe, I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

3 participants