Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2362 message_type_group_map take 2 #2367

Merged
merged 4 commits into from
Dec 5, 2022

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Dec 3, 2022

Further testing revealed that Ensemble-Stat still required that the SURFACE message_type_group_map be defined. Note that the SURFACE setting is used by Ensemble-Stat and Point-Stat to define the message type(s) for which surface verification logic is applied. Rather than erroring out, update Point-Stat and Ensemble-Stat to use default values instead if SURFACE is not specified in the config file. For consistency in logic, handle LANDSF and WATERSF the same way. However, if land_mask is specified, still require that the user actually set them in the config file.

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

  • Ran make test with message_type_group_map = [ ]; and confirmed that Point-Stat and Ensemble-Stat run without error.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Inspect code changes.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • I didn't add any new tests.

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Mon 12/5/22].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…type groups into the PointStatConfInfo::process_geog() function. Only check for these if topo_mask.flag and/or land_mask.flag are true.
…y when SURFACE/LANDSF/WATERSF must be defined.
… It is also used in Ensemble-Stat to define the message types for which surface verification logic should be applied. If not defined in the Point-Stat and Ensemble-Stat config files, use default values. However, if topo_mask and land_mask are enabled in Point-Stat, still require that they actually be defined.
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.0.0 milestone Dec 3, 2022
@JohnHalleyGotway JohnHalleyGotway marked this pull request as ready for review December 5, 2022 18:20
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the code changes and ensured that all tests passed. The code changes are straightforward. I approve this request.

@JohnHalleyGotway JohnHalleyGotway merged commit 6c7fd1a into develop Dec 5, 2022
@JohnHalleyGotway JohnHalleyGotway deleted the feature_2362_message_type_group_map branch December 5, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Relax Point-Stat and Ensemble-Stat logic for the configuration of message_type_group_map
2 participants