Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 1761 percent thresh #1956

Merged
merged 21 commits into from
Nov 3, 2021
Merged

Feature 1761 percent thresh #1956

merged 21 commits into from
Nov 3, 2021

Commits on Oct 20, 2021

  1. Per issue #1761 in set_perc() adding code to get FBIAS numeric value,… 

    … like 1.0 or 0.9, etc. SL
    Seth Linden committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    1e3db4a View commit details
    Browse the repository at this point in the history

  2. Per issue #1761: in set_perc(), modified actual percentile calculatio… 

    …n at end to use the extracted FBIAS numeric value (float). SL
    Seth Linden committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    5ebe49a View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Per issue #1761: modified the check on the perc_thresh_freq_bias, jus… 

    …t has to be > 0 now. SL
    Seth Linden committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    d3885c7 View commit details
    Browse the repository at this point in the history

  2. Per issue #1761: cleaned up code in set_perc(). SL

    Seth Linden committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    716c94f View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2021

  1. Per #1761, updates to Simple_Node::set_perc() to handle variable freq… 

    …uency bias amounts.

Changes include:
- Reverting the formatting of this back to how it originally was in the develop branch. In general, just match the formatting of the existing file, so as the minimize the number of difference lines.
- Add logic to adjust the percentile to be found based on the requested FBIAS value. Multiplying or dividing the percentile by the FBIAS value depends on the inequality type and whether we're bias adjusting the forecast or observation data.
- Adjust the log messages slightly.

Please be aware that I'm not totally confident in these changes. They warrant much more testing. This logic is very, very confusing.
    @JohnHalleyGotway
    JohnHalleyGotway committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    e90bae3 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. Per #1761, call compute_percentile() when double-checking the percent… 

    …ile values.
    @JohnHalleyGotway
    JohnHalleyGotway committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    1f2c5e4 View commit details
    Browse the repository at this point in the history

  2. Per #1761, remove unused variable.

    @JohnHalleyGotway
    JohnHalleyGotway committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    9a156b3 View commit details
    Browse the repository at this point in the history

  3. Per #1761, add warning for percentiles > 100.

    @JohnHalleyGotway
    JohnHalleyGotway committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    d390942 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2021

  1. Per #1761. In set_perc(), after testing cleaned up code. SL

    Seth Linden committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    1f3020d View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2021

  1. Per issue #1761: adding new config file for testing dynamic FBIAS val… 

    …ues. SL
    Seth Linden committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    dc2a45a View commit details
    Browse the repository at this point in the history

  2. Per issue #1761: added new unit test for dynamic FBIAS values when ru… 

    …nning grid_stat. SL
    Seth Linden committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    3315d22 View commit details
    Browse the repository at this point in the history

  3. Per issue #1761, modified FBIAS section to indicated that the user ca… 

    …n use dynamic values that are not 1.0. SL
    Seth Linden committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    d3fc136 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2021

  1. Merge branch 'develop' into feature_1761_percent_thresh

    Seth Linden committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    c7af162 View commit details
    Browse the repository at this point in the history

  2. Update met/docs/Users_Guide/config_options.rst 

    Co-authored-by: johnhg <[email protected]>
    @sethlinden @JohnHalleyGotway
    sethlinden and JohnHalleyGotway authored Nov 2, 2021
    Configuration menu
    Copy the full SHA
    f726324 View commit details
    Browse the repository at this point in the history

  3. Update met/docs/Users_Guide/config_options.rst 

    Co-authored-by: johnhg <[email protected]>
    @sethlinden @JohnHalleyGotway
    sethlinden and JohnHalleyGotway authored Nov 2, 2021
    Configuration menu
    Copy the full SHA
    a3a6457 View commit details
    Browse the repository at this point in the history

  4. Update met/docs/Users_Guide/config_options.rst 

    Co-authored-by: johnhg <[email protected]>
    @sethlinden @JohnHalleyGotway
    sethlinden and JohnHalleyGotway authored Nov 2, 2021
    Configuration menu
    Copy the full SHA
    febf72d View commit details
    Browse the repository at this point in the history

  5. Update test/config/GridStatConfig_fbias_perc_thresh 

    Co-authored-by: johnhg <[email protected]>
    @sethlinden @JohnHalleyGotway
    sethlinden and JohnHalleyGotway authored Nov 2, 2021
    Configuration menu
    Copy the full SHA
    bc82f66 View commit details
    Browse the repository at this point in the history

  6. Update test/config/GridStatConfig_fbias_perc_thresh 

    Co-authored-by: johnhg <[email protected]>
    @sethlinden @JohnHalleyGotway
    sethlinden and JohnHalleyGotway authored Nov 2, 2021
    Configuration menu
    Copy the full SHA
    0017d48 View commit details
    Browse the repository at this point in the history

  7. Update test/config/GridStatConfig_fbias_perc_thresh 

    Co-authored-by: johnhg <[email protected]>
    @sethlinden @JohnHalleyGotway
    sethlinden and JohnHalleyGotway authored Nov 2, 2021
    Configuration menu
    Copy the full SHA
    acd99f5 View commit details
    Browse the repository at this point in the history

  8. Update test/config/GridStatConfig_fbias_perc_thresh 

    Co-authored-by: johnhg <[email protected]>
    @sethlinden @JohnHalleyGotway
    sethlinden and JohnHalleyGotway authored Nov 2, 2021
    Configuration menu
    Copy the full SHA
    6fec6cd View commit details
    Browse the repository at this point in the history

  9. Per issue #1761, set nc_pairs_flag = FALSE. SL

    Seth Linden committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    2124759 View commit details
    Browse the repository at this point in the history