Feature 1855 sonarqube fix strlen & strcpy

[hsoh-u]

Pull Request Testing

• Describe testing already performed for these changes:
  

The behavior should not be changed. SonarQube complains strlen, strcpy, and strncpy as Security Hotspot and make sure them to be safe. strlen & strcpy are replaced to m_strlen & m_strcpy, but the implementation of m_strlen & m_strcpy is not updated yet (need more test). Remaining works are replace strncpy to m_strncpy and enhancing m_strlen, m_strcpy, and m_strncpy.

• src/basic/vx_util/ascii_table.cc: avoid un-initialized variable and checking minimum lines

• src/basic/vx_util/command_line.cc: deleted unreachable code

• src/tools/other/mode_time_domain/mm_engine.cc: avoid two similar for loop

• met/src/tools/other/pb2nc/pb2nc.cc: checks pbl_level before computing PBL and simplify how to find the variables with valid data (checks the first level only). Another issue (Fix PB2NC to better inventory BUFR input data when processing all variables #1894) for checking multiple levels

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

Run the unit test and make sure the same output

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

• Do these changes include sufficient testing updates? [No]

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by 08-31-2021.
  

Pull Request Checklist

See the METplus Workflow for details.

• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Linked issues with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[JohnHalleyGotway]

Suggested change

// column += m_strlen(yytext);

Instead of editing commented out code, let's just remove it.

[JohnHalleyGotway]

Suggested change

// column += m_strlen(yytext);

Instead of editing commented out code, let's just remove it.

[JohnHalleyGotway]

Suggested change

// Column += m_strlen(configtext);

[JohnHalleyGotway]

Suggested change

// Column += m_strlen(configtext);

[JohnHalleyGotway]

I don't know the logic here, but did you intend to remove this return?

[hsoh-u]

The line 753 can not be executed because of the if statement above: continue or exit( 1 )

      if ( AllowUnrecognizedSwitches )  continue;
      else {
         mlog << Error << "\nCommandLine::next_option() -> "
              << "unrecognized command-line switch \"" << args[j] << "\"\n\n";
         exit ( 1 );
      }
      return ( j );  <-- not reachable

[JohnHalleyGotway]

I scrolled through the edits to the 61 modified files. I see that the vast majority of the changes are replacing string functions with the new 'm_'-prefix versions of them. I did recommend removing commented out code instead of modifying it.

I also did merge the current version of develop into the feature_1855_sobarqube_fix (note the typo in the name) branch and then kicked off a full regression test in kiowa:/d1/projects/MET/MET_pull_requests/met-10.1.0/met-10.1.0_beta2/feature_1855/test_regression.log.

Once that regression test completes without error, I'll approve.

[JohnHalleyGotway]

I approve of this PR.

The regression test revealed no diffs when compared against the develop branch, as seen in kiowa:/d1/projects/MET/MET_pull_requests/met-10.1.0/met-10.1.0_beta2/feature_1855/test_regression.log