Feature 1855 sonarqube fix

[hsoh-u]

Pull Request Testing

• remove break statement after return statement

• Avoid un-initialized variables

• Avoid release memory twice

• Avoid null pointer references

• And some bug fixes

• Describe testing already performed for these changes:
  

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

• Do these changes include sufficient testing updates? [No]

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [8/05/2021].
  

Pull Request Checklist

See the METplus Workflow for details.

• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Linked issues with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[JohnHalleyGotway]

Reviewed the 71 modified files and see the following types of changes:

• Removing unreachable break statements that occur after exit(1).
• Checking for null pointers.
• Fix Grid-Stat bug checking for equal numbers of U and V pairs.
• Lining up source code consistently.
• Skip setting values that never get used.

I don't see any obvious problems with these changes. I'm running a full regression test to ensure there aren't any unexpected differences.

met_test@kiowa:/d1/projects/MET/MET_pull_requests/met-10.1.0/met-10.1.0_beta2/feature_1865

[JohnHalleyGotway]

I approve of these changes. After merging the latest from develop into this feature branch, the regression test flagged no differences in the results.