Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate Point2Grid warning when no valid output data is found #3000

Closed
8 of 21 tasks
JohnHalleyGotway opened this issue Oct 21, 2024 · 0 comments · Fixed by #3001
Closed
8 of 21 tasks

Eliminate Point2Grid warning when no valid output data is found #3000

JohnHalleyGotway opened this issue Oct 21, 2024 · 0 comments · Fixed by #3001
Assignees
Labels
component: code cleanup Code cleanup and maintenance issue priority: medium Medium Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Oct 21, 2024

Describe the Enhancement

As requested in the dtcenter/METplus#2738 discussion, eliminate the warning message printed by the Point2Grid tool when no valid data is written to the output. Generally speaking, warnings are written by the MET tools to alert users of unexpected behavior. The situation described by @Ho-ChunHuang-NOAA, that Point2Grid should expect little to no high quality observed AOD during overnight hours means that no valid output values really can be expected outcome.

In order to satisfy NCO requirements to minimize or eliminate warning messages entirely, recommend modifying that log message to report it as DEBUG(2) log level rather than a warning message.

Time Estimate

~2 hours

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None needed

Relevant Deadlines

Include in MET-12.0.0-rc1 release to be available for EVS v2.0.

Funding Source

Need to confirm: 2783544 NOAA R2O METplus

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as a MET-X.Y.Z version, Consider for Next Release, or Backlog of Development Ideas
  • For a MET-X.Y.Z version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing component: code cleanup Code cleanup and maintenance issue requestor: NOAA/EMC NOAA Environmental Modeling Center priority: medium Medium Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project labels Oct 21, 2024
@JohnHalleyGotway JohnHalleyGotway added this to the MET-12.0.0 milestone Oct 21, 2024
@JohnHalleyGotway JohnHalleyGotway self-assigned this Oct 21, 2024
JohnHalleyGotway added a commit that referenced this issue Oct 21, 2024
…mize the number of warning messages Point2Grid writes. However, do retain the warnings about problems writing the grid mapping output file.
@JohnHalleyGotway JohnHalleyGotway linked a pull request Oct 21, 2024 that will close this issue
17 tasks
@JohnHalleyGotway JohnHalleyGotway moved this from 🟢 Ready to 🔎 In review in MET-12.0.0 Development Oct 21, 2024
JohnHalleyGotway added a commit that referenced this issue Oct 21, 2024
* Per #3000, change 9 warning messages to Debug(2) log messages to minimize the number of warning messages Point2Grid writes. However, do retain the warnings about problems writing the grid mapping output file.

* Per #3000 very minor whitespace diffs
@github-project-automation github-project-automation bot moved this from 🔎 In review to 🏁 Done in MET-12.0.0 Development Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: code cleanup Code cleanup and maintenance issue priority: medium Medium Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing
Projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

1 participant