Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Provide instructions for compiling MET with the C++11 standard #2949

Closed
8 of 22 tasks
jprestop opened this issue Aug 20, 2024 · 1 comment · Fixed by #2973
Closed
8 of 22 tasks

Documentation: Provide instructions for compiling MET with the C++11 standard #2949

jprestop opened this issue Aug 20, 2024 · 1 comment · Fixed by #2973
Assignees
Labels
component: documentation Documentation issue priority: high High Priority requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: task An actionable item of work
Milestone

Comments

@jprestop
Copy link
Collaborator

jprestop commented Aug 20, 2024

Describe the Task

Due to the issue Modify configure.ac to require the C++17 standard #2948, provide instructions for users can compile MET with the C++11 standard.

Update the screenshot in this section to include the newer versions of ecKit and ATLAS.

Review the rest of the page for any other necessary changes.

Time Estimate

1-3 days of work

Sub-Issues

Consider breaking the task down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

MET-12.0.0-rc1 release

Funding Source

TBD

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as a MET-X.Y.Z version, Consider for Next Release, or Backlog of Development Ideas
  • For a MET-X.Y.Z version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@jprestop jprestop added component: documentation Documentation issue type: task An actionable item of work alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project priority: high High Priority labels Aug 20, 2024
@jprestop jprestop added this to the MET 12.0.0 milestone Aug 20, 2024
@jprestop jprestop self-assigned this Aug 20, 2024
@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Aug 20, 2024

Based on brainstorming with @j-opatz in Slack, recommend taking the following approach.

  1. Add support in the MET configure.ac file for a new environment variable named MET_CXX_STANDARD (or something similar).
  2. Update configure.ac to add MET_CXX_STANDARD it to the list of "influential env vars" along with a description of how it works.
  3. Update configure.ac to check to see if it's set. If so, set a local variable to the same value. If not, set that local variable to the default value of 17.
  4. Update configure.ac so that the CXXFLAGS setting includes -std=c++${MET_CXX_STANDARD}... or something similar to specify the C++ standard flag that should be used.

@jprestop jprestop removed the required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone label Aug 22, 2024
@jprestop jprestop mentioned this issue Aug 26, 2024
17 tasks
@JohnHalleyGotway JohnHalleyGotway added required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone and removed required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project labels Sep 5, 2024
@jprestop jprestop moved this from 🟢 Ready to 🏗 In progress in MET-12.0.0 Development Sep 16, 2024
jprestop added a commit that referenced this issue Sep 16, 2024
@jprestop jprestop moved this from 🏗 In progress to 🔎 In review in MET-12.0.0 Development Sep 16, 2024
@jprestop jprestop linked a pull request Sep 16, 2024 that will close this issue
17 tasks
jprestop added a commit that referenced this issue Sep 19, 2024
* Per #2949, updating installation instructions

* Per #2949, adding missing colon from note directive

* Per #2949, third attempt to get the new note to show up

* Per #2949, modifying text and format

* Per #2949, removing images in favor of code blocks for easier modification

* Per #2949, modified wording for clarity

* Per #2929, corrected typo

* Update installation.rst

No changes to content, only whitespace for consistency, mostly removing tabs.

* Update docs/Users_Guide/installation.rst

Co-authored-by: John Halley Gotway <[email protected]>

* Per #2949, testing variable replacement, expect failures

* Per #2949, reverting to orignal state after testing

---------

Co-authored-by: John Halley Gotway <[email protected]>
@github-project-automation github-project-automation bot moved this from 🔎 In review to 🏁 Done in MET-12.0.0 Development Sep 19, 2024
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: documentation Documentation issue priority: high High Priority requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: task An actionable item of work
Projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

2 participants