Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default setting for the model string from "WRF" to "FCST" in the default MET configuration files #2682

Closed
8 of 21 tasks
JohnHalleyGotway opened this issue Sep 14, 2023 · 0 comments · Fixed by #2683
Assignees
Labels
MET: Configuration priority: medium Medium Priority requestor: METplus Team METplus Development Team type: task An actionable item of work
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

Describe the Task

The default model string listed in the Grid-Stat config file is "WRF".

model = "WRF";

That setting exists in 9 of the default MET configuration files. It originated back when MET was initially named WVT, for the WRF Verification Toolkit. This issue is to change the default from WRF to FCST, which is what most of the METplus wrappers do anyway.

Time Estimate

1 hour.

Sub-Issues

Consider breaking the task down into sub-issues.
None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next official version or Backlog of Development Ideas
  • For the next official version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: task An actionable item of work priority: medium Medium Priority requestor: METplus Team METplus Development Team MET: Configuration labels Sep 14, 2023
@JohnHalleyGotway JohnHalleyGotway added this to the MET 12.0.0 milestone Sep 14, 2023
@JohnHalleyGotway JohnHalleyGotway self-assigned this Sep 14, 2023
@JohnHalleyGotway JohnHalleyGotway moved this from 🔖 Ready to 👀 In review in MET-12.0.0 Development Sep 14, 2023
@JohnHalleyGotway JohnHalleyGotway linked a pull request Sep 15, 2023 that will close this issue
15 tasks
@JohnHalleyGotway JohnHalleyGotway moved this from 👀 In review to ✅ Done in MET-12.0.0 Development Sep 15, 2023
@JohnHalleyGotway JohnHalleyGotway changed the title Modify the model strings in the default MET configuration files Change the default setting for the model string from "WRF" to "FCST" in the default MET configuration files Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Configuration priority: medium Medium Priority requestor: METplus Team METplus Development Team type: task An actionable item of work
Projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

1 participant