Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanity check to error out when both is_u_wind and is_v_wind are set to true #2357

Closed
6 of 20 tasks
JohnHalleyGotway opened this issue Nov 28, 2022 · 0 comments · Fixed by #2358
Closed
6 of 20 tasks
Assignees
Labels
MET: Configuration priority: medium Medium Priority reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: Community General Community type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

Describe the Enhancement

This issue arose in the dtcenter/METplus#1970 discussion. The user defined both is_u_wind = TRUE; and is_v_wind = TRUE; inside the fcst and obs dictionaries rather than specifying them separately for each field. This certainly is an easy thing to do and warrants that more error checking be added to MET.

In VarInfo::set_dict(...), add a check so that if both is_u_wind and is_v_wind are set, we error out and write a useful error message.

Time Estimate

2 hours.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing priority: medium Medium Priority requestor: Community General Community alert: NEED ACCOUNT KEY Need to assign an account key to this issue MET: Configuration labels Nov 28, 2022
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.0.0 milestone Nov 28, 2022
@JohnHalleyGotway JohnHalleyGotway changed the title Enhance the MET tools to error out if the same field is identified as containing both the U and V components of wind Enhance the MET tools to error out when both is_u_wind and is_v_wind are set Nov 28, 2022
JohnHalleyGotway added a commit that referenced this issue Nov 28, 2022
@JohnHalleyGotway JohnHalleyGotway linked a pull request Nov 28, 2022 that will close this issue
15 tasks
JohnHalleyGotway added a commit that referenced this issue Nov 29, 2022
@JohnHalleyGotway JohnHalleyGotway self-assigned this Nov 30, 2022
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Nov 30, 2022
@JohnHalleyGotway JohnHalleyGotway changed the title Enhance the MET tools to error out when both is_u_wind and is_v_wind are set Add sanity check to error out when both is_u_wind and is_v_wind are set to true Dec 9, 2022
@TaraJensen TaraJensen added reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA R2O NOAA Research to Operations DTC Project labels Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Configuration priority: medium Medium Priority reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: Community General Community type: enhancement Improve something that it is currently doing
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants