Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update map data with more recent NaturalEarth definitions #2207

Closed
15 of 20 tasks
georgemccabe opened this issue Jul 13, 2022 · 0 comments · Fixed by #2241
Closed
15 of 20 tasks

Update map data with more recent NaturalEarth definitions #2207

georgemccabe opened this issue Jul 13, 2022 · 0 comments · Fixed by #2241
Assignees
@JohnHalleyGotway
Labels
MET: Plotting Tools priority: medium Medium Priority reporting: DTC NCAR Base NCAR Base DTC Project requestor: Community General Community type: enhancement Improve something that it is currently doing
Milestone
MET 11.0.0

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Jul 13, 2022 •
edited by JohnHalleyGotway
Loading

This was brought to our attention in Discussion dtcenter/METplus#1695

The map data that is provided with the MET software should be updated.

In a Slack discussion with @JohnHalleyGotway, he suggested that we update the map data to match the latest from https://www.naturalearthdata.com. He also suggested the following:

Alternatively, we could switch to specifying map data as shapefiles instead to make swapping out map data much easier. But that'd require some coding work, config file changes, and decisions about how to decide what to plot.

The user who brought this to our attention provided a zip file that contains shapefiles with updated state boundaries for India. We should confirm that the updated maps from the Natural Earth website match what is contained in this file.

Describe the Enhancement

Provide a description of the enhancement request here.

Time Estimate

2 days

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2792541

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Jul 13, 2022
@georgemccabe georgemccabe added this to the MET 11.0.0 milestone Jul 13, 2022
@JohnHalleyGotway JohnHalleyGotway added priority: medium Medium Priority requestor: Community General Community MET: Plotting Tools and removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required labels Jul 28, 2022
@JohnHalleyGotway JohnHalleyGotway self-assigned this Jul 28, 2022
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Jul 28, 2022
@JohnHalleyGotway JohnHalleyGotway moved this from To Do to In Progress in MET-11.0.0-beta3 (9/21/22) Aug 11, 2022
JohnHalleyGotway added a commit that referenced this issue Aug 11, 2022
@JohnHalleyGotway
Per #2207, fix typo in program name.
ad5167d
JohnHalleyGotway added a commit that referenced this issue Aug 12, 2022
@JohnHalleyGotway
Per #2207, when processing shapefiles for Indian states, I had to inc…
865d166 
…rease this buffer. Would be much better if we dynamically allocated this instead.
JohnHalleyGotway added a commit that referenced this issue Aug 12, 2022
@JohnHalleyGotway
Per #2207, updates to the map data based on Natural Earth shapefiles …
82c3852 
…version 5.5.1
@JohnHalleyGotway JohnHalleyGotway changed the title Update map data Update map data with more recent NaturalEarth definitions Aug 23, 2022
JohnHalleyGotway added a commit that referenced this issue Aug 24, 2022
@JohnHalleyGotway
Per #2207, still deciding what map data we should actually provide. R…
c5bc0b1 
…emoved the admin_data file since it was an exact copy of the admin_by_country data and breaking it down by country is likely more useful. Did also add country_major_lakes_detail_data to provide global 10M outlines. I worry that these datafiles are TOO LARGE.
JohnHalleyGotway added a commit that referenced this issue Aug 25, 2022
@JohnHalleyGotway
Per #2207, add images showing the map data.
0f87d42
JohnHalleyGotway added a commit that referenced this issue Aug 25, 2022
@JohnHalleyGotway
Per #2207, several changes:
9c01db5 
- Modified admin_Curacao_data to remove the odd character.
- Updated the major_lakes_data to make it match the 110m data, as documented.
- Deleted the country_major_lakes_data since make_mapfiles errors out on it anyway. Also, it is NOT referenced in the default map data in ConfigMapData.
- Added admin_by_country_data.png to show the level of detail available.
@JohnHalleyGotway JohnHalleyGotway linked a pull request Aug 25, 2022 that will close this issue
Feature 2207 map #2241
Merged
15 tasks
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Aug 25, 2022
JohnHalleyGotway added a commit that referenced this issue Aug 25, 2022
@JohnHalleyGotway
Per #2207, adding country_major_lakes_data back in since the WWMCA pl…
87932b6 
…ot code is hard-coded to plot this data.
@JohnHalleyGotway JohnHalleyGotway moved this from In Progress to Pull Request Review in MET-11.0.0-beta3 (9/21/22) Aug 26, 2022
JohnHalleyGotway added a commit that referenced this issue Aug 26, 2022
@JohnHalleyGotway
Per #2207, I realized that these PNG images could be made smaller. So…
3674bbf 
… I resized them all to 960x480 to match the dimensions of the MET flowchart images. This reduces the file size a lot.
@JohnHalleyGotway JohnHalleyGotway mentioned this issue Aug 26, 2022
Merged
Repository owner moved this from Pull Request Review to Done in MET-11.0.0-beta3 (9/21/22) Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnHalleyGotway JohnHalleyGotway

Labels
MET: Plotting Tools priority: medium Medium Priority reporting: DTC NCAR Base NCAR Base DTC Project requestor: Community General Community type: enhancement Improve something that it is currently doing
Projects
No open projects
MET-11.0.0-beta3 (9/21/22)
Status: Done
Milestone
MET 11.0.0
Development

Successfully merging a pull request may close this issue.

Feature 2207 map dtcenter/MET
2 participants
@JohnHalleyGotway @georgemccabe