Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement the pntnc2ascii.R utility Rscript in Python. #2085

Closed
6 of 20 tasks
JohnHalleyGotway opened this issue Mar 4, 2022 · 0 comments · Fixed by #2341
Closed
6 of 20 tasks

Reimplement the pntnc2ascii.R utility Rscript in Python. #2085

JohnHalleyGotway opened this issue Mar 4, 2022 · 0 comments · Fixed by #2341
Assignees
Labels
component: code cleanup Code cleanup and maintenance issue MET: PreProcessing Tools (Point) priority: medium Medium Priority requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Mar 4, 2022

Describe the Enhancement

This issue arose via this METplus Discussion. The METplus team recommended that @PerryShafran-NOAA run the pntnc2ascii.R Rscript to dump the NetCDF output from PB2NC prior to interrogating that data further. That script is very useful and really helps with debugging, but it cannot be run on WCOSS or Hera due to R package dependencies.

This task is to reimplement this functionality in Python instead of R, making sure that it uses Python packages actually available on WCOSS and Hera.

The Rscript currently lives in "met/scripts/Rscripts". The python implementation could be stored in "met/scripts/python". However, I'd recommend re-evaluating the final location for this. Does it really belong in the METplus repo? Or perhaps the METdatadb repo after it's been named to METdataio? Or perhaps it does belong in MET, but should be placed in a new "met/scripts/utility" directory?

Recommend removing the old pntnc2ascii.R script once the Python version has replaced it.

Note that the majority of this work is likely already done in read_met_point_obs.py. We could just modify it to provide an option to write the observations to stdout. Or support a "-out" command line option to write the data to an output file.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
No sub-issues needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2773542

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing component: code cleanup Code cleanup and maintenance issue requestor: NOAA/EMC NOAA Environmental Modeling Center priority: medium Medium Priority alert: NEED MORE DEFINITION Not yet actionable, additional definition required MET: PreProcessing Tools (Point) labels Mar 4, 2022
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.0.0 milestone Mar 4, 2022
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED MORE DEFINITION Not yet actionable, additional definition required label Mar 8, 2022
@hsoh-u hsoh-u self-assigned this Mar 17, 2022
@TaraJensen TaraJensen added the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Apr 21, 2022
@hsoh-u hsoh-u moved this from Todo to In Progress in METplus-Wrappers-5.0.0-beta4 (10/26/22) Oct 19, 2022
@hsoh-u hsoh-u moved this from In Progress to Todo in METplus-Wrappers-5.0.0-beta4 (10/26/22) Oct 19, 2022
@georgemccabe georgemccabe moved this from Backlog to To Do in MET-11.0.0-beta4 (11/02/22) Oct 20, 2022
@JohnHalleyGotway JohnHalleyGotway moved this from Backlog to In Progress in MET-11.0.0-beta5 (11/20/22) Oct 27, 2022
@JohnHalleyGotway JohnHalleyGotway moved this from In Progress to Todo in MET-11.0.0-beta5 (11/20/22) Oct 27, 2022
@hsoh-u hsoh-u moved this from Todo to In Progress in MET-11.0.0-beta5 (11/20/22) Oct 28, 2022
@TaraJensen TaraJensen removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Oct 28, 2022
hsoh-u pushed a commit that referenced this issue Nov 5, 2022
hsoh-u pushed a commit that referenced this issue Nov 5, 2022
hsoh-u pushed a commit that referenced this issue Nov 9, 2022
@hsoh-u hsoh-u linked a pull request Nov 10, 2022 that will close this issue
15 tasks
@hsoh-u hsoh-u moved this from In Progress to Pull Request Review in MET-11.0.0-beta5 (11/20/22) Nov 10, 2022
hsoh-u pushed a commit that referenced this issue Nov 17, 2022
hsoh-u pushed a commit that referenced this issue Nov 17, 2022
hsoh-u pushed a commit that referenced this issue Nov 17, 2022
hsoh-u pushed a commit that referenced this issue Nov 17, 2022
hsoh-u pushed a commit that referenced this issue Nov 17, 2022
hsoh-u pushed a commit that referenced this issue Nov 17, 2022
hsoh-u pushed a commit that referenced this issue Nov 17, 2022
hsoh-u pushed a commit that referenced this issue Nov 17, 2022
hsoh-u pushed a commit that referenced this issue Nov 17, 2022
hsoh-u pushed a commit that referenced this issue Nov 17, 2022
@hsoh-u hsoh-u closed this as completed Nov 18, 2022
Repository owner moved this from Pull Request Review to Done in MET-11.0.0-beta5 (11/20/22) Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: code cleanup Code cleanup and maintenance issue MET: PreProcessing Tools (Point) priority: medium Medium Priority requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants