Fix fsharp#672

dsyme · Mar 8, 2017 · 95e3a18 · 95e3a18
1 parent c59d51b
commit 95e3a18
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -1,3 +1,6 @@
+#### 11.0.5
+  * Fix [stack overflow exception](https://github.com/fsharp/FSharp.Compiler.Service/issues/672)
+
 #### 11.0.4
   * Fix [out of range exception](https://github.com/fsharp/FSharp.Compiler.Service/issues/709)
 

diff --git a/src/fsharp/FSharp.Compiler.Service.ProjectCrackerTool/ProjectCrackerTool.fs b/src/fsharp/FSharp.Compiler.Service.ProjectCrackerTool/ProjectCrackerTool.fs
@@ -431,7 +431,8 @@ module internal ProjectCrackerTool =
     let onResolveEvent = new ResolveEventHandler(fun sender evArgs ->
       let requestedAssembly = AssemblyName(evArgs.Name)
       if requestedAssembly.Name.StartsWith("Microsoft.Build") &&
-          not (requestedAssembly.Name.EndsWith(".resources")) then
+          not (requestedAssembly.Name.EndsWith(".resources")) && 
+          not (requestedAssembly.Version.ToString().Contains("12.0.0.0")) then
         // If the version of MSBuild that we're using wasn't present on the machine, then 
         // just revert back to 12.0.0.0 since that's normally installed as part of the .NET 
         // Framework.