Added ability for middlewares to overwrite data for Response_VM #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good; I just wasn't expecting outgoing data to be modified, but apparently you have a use case for it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on a middleware for buffering updates (i.e. no more than 1 update per X seconds) and had no way of merging objects together as the Response_VM middleware wasn't using the updated Data field.
Looking throughout the code for calling the middlewares, I saw that you used ctx.Data sometimes and sometimes not. I'm not sure if the inconsistency was intended or not, but things seem to be working normally from my tests.